The general makefile targets:

 all clean distclean depend install install_examples

are defined in every single makefile. This caused missing or
incomplete phony targets in some makefiles. This patch moves the phony
target definition to rules.mk that is included in every makefile.

Signed-off-by: Robert Richter <robert.rich...@amd.com>
---
 Makefile                    |    2 +-
 docs/Makefile               |    2 --
 examples/Makefile           |    1 -
 examples/ia64/Makefile      |    1 -
 examples/x86/Makefile       |    1 -
 examples_ia64_v2.0/Makefile |    1 -
 examples_v2.x/Makefile      |    1 -
 examples_v2.x/ia64/Makefile |    1 -
 examples_v2.x/x86/Makefile  |    1 -
 include/Makefile            |    2 +-
 libpfms/Makefile            |    1 -
 libpfms/lib/Makefile        |    1 -
 rules.mk                    |    2 ++
 13 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/Makefile b/Makefile
index 885b1b0..ac477ae 100644
--- a/Makefile
+++ b/Makefile
@@ -67,6 +67,6 @@ install:
 install_examples:
        $(MAKE) -C examples $@
 
-.PHONY: all clean distclean depend tar tarcvs install install_examples lib
+.PHONY: tar tarcvs lib
 
 # DO NOT DELETE
diff --git a/docs/Makefile b/docs/Makefile
index 795a216..525c466 100644
--- a/docs/Makefile
+++ b/docs/Makefile
@@ -25,8 +25,6 @@ TOPDIR  := $(shell if [ "$$PWD" != "" ]; then echo $$PWD; 
else pwd; fi)/..
 include $(TOPDIR)/config.mk
 include $(TOPDIR)/rules.mk
 
-.PHONY: all clean distclean depend
-
 ifeq ($(CONFIG_PFMLIB_ARCH_IA64),y)
 ARCH_MAN=libpfm_itanium.3 libpfm_itanium2.3 libpfm_montecito.3
 endif
diff --git a/examples/Makefile b/examples/Makefile
index 5955848..c1cb3bf 100644
--- a/examples/Makefile
+++ b/examples/Makefile
@@ -91,4 +91,3 @@ install_examples:
 #
 # examples are installed as part of the RPM install, typically in 
/usr/share/doc/libpfm-X.Y/
 #
-.PHONY: install depend install_examples
diff --git a/examples/ia64/Makefile b/examples/ia64/Makefile
index 9e3c306..860b5c9 100644
--- a/examples/ia64/Makefile
+++ b/examples/ia64/Makefile
@@ -63,4 +63,3 @@ install_examples:
 #
 # examples are installed as part of the RPM install, typically in 
/usr/share/doc/libpfm-X.Y/
 #
-.PHONY: install install_examples
diff --git a/examples/x86/Makefile b/examples/x86/Makefile
index 133da08..45dd17f 100644
--- a/examples/x86/Makefile
+++ b/examples/x86/Makefile
@@ -51,4 +51,3 @@ install_examples:
 #
 # examples are installed as part of the RPM install, typically in 
/usr/share/doc/libpfm-X.Y/
 #
-.PHONY: install depend install_examples
diff --git a/examples_ia64_v2.0/Makefile b/examples_ia64_v2.0/Makefile
index b58a103..44a4ca1 100644
--- a/examples_ia64_v2.0/Makefile
+++ b/examples_ia64_v2.0/Makefile
@@ -81,4 +81,3 @@ depend:
 #
 # examples are installed as part of the RPM install, typically in 
/usr/share/doc/libpfm-X.Y/
 #
-.PHONY: install
diff --git a/examples_v2.x/Makefile b/examples_v2.x/Makefile
index 5955848..c1cb3bf 100644
--- a/examples_v2.x/Makefile
+++ b/examples_v2.x/Makefile
@@ -91,4 +91,3 @@ install_examples:
 #
 # examples are installed as part of the RPM install, typically in 
/usr/share/doc/libpfm-X.Y/
 #
-.PHONY: install depend install_examples
diff --git a/examples_v2.x/ia64/Makefile b/examples_v2.x/ia64/Makefile
index 9e3c306..860b5c9 100644
--- a/examples_v2.x/ia64/Makefile
+++ b/examples_v2.x/ia64/Makefile
@@ -63,4 +63,3 @@ install_examples:
 #
 # examples are installed as part of the RPM install, typically in 
/usr/share/doc/libpfm-X.Y/
 #
-.PHONY: install install_examples
diff --git a/examples_v2.x/x86/Makefile b/examples_v2.x/x86/Makefile
index cbd9df1..d0ef7b2 100644
--- a/examples_v2.x/x86/Makefile
+++ b/examples_v2.x/x86/Makefile
@@ -51,4 +51,3 @@ install_examples:
 #
 # examples are installed as part of the RPM install, typically in 
/usr/share/doc/libpfm-X.Y/
 #
-.PHONY: install depend install_examples
diff --git a/include/Makefile b/include/Makefile
index 01864e1..cab3388 100644
--- a/include/Makefile
+++ b/include/Makefile
@@ -109,7 +109,7 @@ HEADERS += perfmon/pfmlib_os_crayx2.h   \
           perfmon/pfmlib_crayx2.h
 endif
 
-.PHONY: all clean distclean depend perfmon.h dir
+.PHONY:        perfmon.h dir
 
 perfmon.h: dir
 
diff --git a/libpfms/Makefile b/libpfms/Makefile
index 8ecf513..30588fd 100644
--- a/libpfms/Makefile
+++ b/libpfms/Makefile
@@ -46,7 +46,6 @@ distclean: clean
 lib/libpfms.a: 
        @set -e ; $(MAKE) -C lib all
 
-.PHONY: install depend
 install depend: $(TARGETS)
 
 install depend:
diff --git a/libpfms/lib/Makefile b/libpfms/lib/Makefile
index cc44748..2efc2bd 100644
--- a/libpfms/lib/Makefile
+++ b/libpfms/lib/Makefile
@@ -84,7 +84,6 @@ clean:
 
 distclean: clean
 
-.PHONY: install depend
 install: $(TARGETS)
 
 install:
diff --git a/rules.mk b/rules.mk
index 67ee1e0..49cd6fd 100644
--- a/rules.mk
+++ b/rules.mk
@@ -24,6 +24,8 @@
 #
 .SUFFIXES: .c .S .o .lo .cpp
 
+.PHONY: all clean distclean depend install install_examples
+
 .S.o:
        $(CC) $(CFLAGS) -c $*.S
 .c.o:
-- 
1.6.1.2



------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
perfmon2-devel mailing list
perfmon2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/perfmon2-devel

Reply via email to