Yes, I think I could combine those. The only issue is that the tables and structures are auto-generated for each processor, and the script that generates them only looks at one at a time, so it doesn't detect commonality. There may be an easy way to fix this... I'll look into it.
That would result in a much larger patch, though. Is that ok? Maybe you could commit the existing Power7 patch first, and then I make another patch which consolidates the common types for all of the processors? I'm ok with either method. Let me know. Regards, - Corey Corey Ashford Software Engineer IBM Linux Technology Center, Linux Toolchain Beaverton, OR 503-578-3507 cjash...@us.ibm.com stephane eranian wrote: > Corey, > > I looked at the patch today. > > I am just wondering about a few things: > > - it looks like the event table entries for Power 5, 6, 7 all use > the same format. I think it would > simplify things if common types would be put in common for all > Power processors. In libpfm4, > I will be doing this for Intel X86, for instance. In your case it > will simplify headers but also the > code, e.g., you will be able to get rid of some of the switch() > statements. > > Thanks. -- Regards, - Corey Corey Ashford Software Engineer IBM Linux Technology Center, Linux Toolchain Beaverton, OR 503-578-3507 cjash...@us.ibm.com ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ perfmon2-devel mailing list perfmon2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
