On Tue, 2009-08-25 at 15:17 +1000, Paul Mackerras wrote: > Currently, if a group is created where the group leader is initially > disabled but a non-leader member is initially enabled, and then the > leader is subsequently enabled some time later, the time_enabled for > the non-leader member will reflect the whole time since it was created, > not just the time since the leader was enabled. This is incorrect, > because all of the members are effectively disabled while the leader > is disabled, since none of the members can go on the PMU if the leader > can't. > > Thus we have to update the ->tstamp_enabled for all the enabled group > members when a group leader is enabled, so that the time_enabled > computation only counts the time since the leader was enabled. > Similarly, when disabling a group leader we have to update the > time_enabled and time_running for all of the group members. > Also, in update_counter_times, we have to treat a counter whose group > leader is disabled as being disabled. > > Reported-by: Stephane Eranian <eran...@googlemail.com> > Signed-off-by: Paul Mackerras <pau...@samba.org>
Looks good, thanks Paul! ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ perfmon2-devel mailing list perfmon2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
