* Stephane Eranian <[email protected]> wrote:
> +struct evt_cstr {
> + unsigned long idxmsk[BITS_TO_LONGS(X86_PMC_IDX_MAX)];
> + int code;
> +};
> +
> +#define EVT_CSTR0(c, m) { .code = (c), .idxmsk[0] = (m) }
> +#define EVT_CSTR_END { .code = 0, .idxmsk[0] = 0 }
> +
> +#define for_each_evt_cstr(e, c) \
> + for((e) = (c); (e)->idxmsk[0]; (e)++)
Nice patch - but the naming here absolutely sucked, so i changed
evt_cstr, idxmsk, CSTR, etc. to something more palatable. Field names
and abstractions in Linux code really need to be meaningful, and the
code has to be readable and understandable. Wdntusabbrntslkthtinlnx :)
Ingo
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
perfmon2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
