On Mon, May 17, 2010 at 12:04:01PM +0200, Stephane Eranian wrote: > The -c option defines the user requested sampling period. It was implemented > using an unsigned int variable but the type of the option was OPT_LONG. > Thus, > the option parser was overwriting memory belonging to other variables, > namely > the mmap_pages leading to a zero page sampling buffer. The bug was exposed > only when compiling at -O0, probably because the compiler was padding > variables at higher optimization levels. > > This patch fixes this problem by declaring user_interval as u64. This also > avoids wrap-around issues for large period on 32-bit systems. > > Signed-off-by: Stephane Eranian <eran...@google.com>
Acked-by: Frederic Weisbecker <fweis...@gmail.com> Small detail: could you avoid the spaces in the beginning of your changelog lines? May be that's because you use git-show to dump your patches? In which case I suggest you to use git-format-patch instead. Thanks. ------------------------------------------------------------------------------ _______________________________________________ perfmon2-devel mailing list perfmon2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
