On Sat, Sep 25, 2010 at 11:51 AM, Peter Zijlstra <pet...@infradead.org> wrote: > On Wed, 2010-09-22 at 12:26 +0200, Stephane Eranian wrote: > >> Ok, early testing shows that this seems to be working fine with the >> pid approach. Of course it is less convenient than just opening a file >> descriptor in cgroup_fs. There is more bookkeeping involved, incl. >> cleanup the child on exit. > > Right, so another approach, similar to what you initially proposed, > would be to have this cgroup file, but instead of simply opening and > passing the fd around, have it provide a cgroup id and pass that around > as an integer (or pid_t) in the task argument to the SYSCALL (see the > flag bit below). > > You can use the regular lib/idr.c bits to generate ids and maintain an > id->cgroup map. > What's the advantage of that compared to just passing the fd in the pid argument? You can close the fd right after returning from perf_event_open().
>> The other thing is related to how to indicate we want cgroup and not >> per-thread. >> For now, my patch is using a new attr.cgroup bit. The alternative is to use a >> bit in the flags parameter to the syscall. > > Right, I prefer a bit in the syscall flags argument and somehow using > the task argument. > ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ perfmon2-devel mailing list perfmon2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
