On 11/02/2010 02:04 PM, stephane eranian wrote: > Corey, > > Seems this is dependent (or reusing) some of the PowerPC definitions. > Is that correct?
Yes, it's using some of the PowerPC functions, and is designed to work with a Power7 PMU in the same machine, differentiating the PMU by the lower 32 bits of the event code being in the range 0x0100_0000 - 0x01FF_FFFF. > > Instead of having empty descriptions encoded hundreds of times in > the table, I think it would be cleaner to handle pme_desc == NULL > in get_event_info(). That's a good idea. I'll reformulate a patch with this change, and also remove a bogus comment near the end: /* the next 4 fields are initialized in pfm_gen_powerpc_pmu_detect */ - Corey ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ perfmon2-devel mailing list perfmon2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
