On Thu, Nov 25, 2010 at 12:20 PM, Peter Zijlstra <pet...@infradead.org>wrote:

> On Thu, 2010-11-18 at 12:40 +0200, Stephane Eranian wrote:
> > @@ -919,6 +945,10 @@ static inline void perf_event_task_sched_in(struct
> task_struct *task)
> >  static inline
> >  void perf_event_task_sched_out(struct task_struct *task, struct
> task_struct *next)
> >  {
> > +#ifdef CONFIG_CGROUPS
> > +       atomic_t *cgroup_events = &__get_cpu_var(perf_cgroup_events);
> > +       COND_STMT(cgroup_events, perf_cgroup_switch(task, next));
> > +#endif
> >         COND_STMT(&perf_task_events, __perf_event_task_sched_out(task,
> next));
> >  }
>
> I don't think that'll actually work, the jump label stuff needs a static
> address.
>
> I did not know that.


> Why not simply: s/perf_task_events/perf_sched_events/ and increment it
> for cgroup events as well?
>
> But you would need to demultiplex. that's not because perf_sched_events is
set that you want BOTH perf_cgroup_switch() AND
perf_event_task_sched_out().
------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
perfmon2-devel mailing list
perfmon2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/perfmon2-devel

Reply via email to