On Wed, Mar 23, 2011 at 12:36 PM, Ingo Molnar <mi...@elte.hu> wrote:
>
> * Stephane Eranian <eran...@google.com> wrote:
>
>> - if (is_cgroup_event(event))
>> + if (is_cgroup_event(event)) {
>> ctx->nr_cgroups--;
>> + cpuctx = __get_cpu_context(ctx);
>> + /*
>> + * if there are no more cgroup events
>> + * then clear cgrp to avoid stale pointer
>> + * in update_cgrp_time_from_cpuctx()
>> + */
>> + if (!ctx->nr_cgroups)
>> + cpuctx->cgrp = NULL;
>> + }
>
> The ->cgrp pointer does not exist on !CGROUPS kernels. I suspect the cleanest
> approach would be to make those two cgrp fields available unconditionally in
> struct perf_event.
>
Argh, I forgot to test !CGROUP.
I tend to agree with you on making those fields unconditional. We
don't save that
much by not doing it.
> Thanks,
>
> Ingo
>
------------------------------------------------------------------------------
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software
be a part of the solution? Download the Intel(R) Manageability Checker
today! http://p.sf.net/sfu/intel-dev2devmar
_______________________________________________
perfmon2-devel mailing list
perfmon2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
