On 03/15/2012 02:37 PM, William Cohen wrote: > On 03/15/2012 12:51 PM, stephane eranian wrote: >> Patch applied. >> Please pull and verifies that it works for you. >> Thanks. >> >> On Wed, Mar 14, 2012 at 9:21 PM, William Cohen <wco...@redhat.com> wrote: >>> Hi, >>> >>> I took a look at the rpm spec file for libpfm in the libpfm-4.2.0.tar.gz. >>> Attached is the revised version: >>> >>> -Allow the python support to be include or excluded from rpmbuild >>> -change spec file name to libpfm.spec (no need for the '4' in there) >>> -adjust summary and line lengths (no '.' and limit length of lines) >>> -allow parallel makes of libpfm >>> -avoid having libpfm-devel own man3 directory >>> -proper version information in changelog >>> >>> -Will > > Hi Stephane, > > The spec file change works fine. I was able to build the rpms with: > > git archive --prefix=libpfm-4.2.0/ --format=tar HEAD | gzip > > libpfm-4.2.0.tar.gz > rpmbuild -ta libpfm-4.2.0.tar.gz > > > -Will
Hi Stephane, I submitted a Fedora bugzilla to review the spec file: https://bugzilla.redhat.com/show_bug.cgi?id=804666 Some additional suggestions for libpfm.spec file were made. I have updated the libpfm.spec file to address those comments. When running rpmlint on the resulting rpm there were a couple issues with the python code were flagged: libpfm-python.x86_64: E: non-executable-script /usr/lib64/python2.6/site-packages/perfmon/pmu.py 0644L /usr/bin/env libpfm-python.x86_64: E: non-executable-script /usr/lib64/python2.6/site-packages/perfmon/session.py 0644L /usr/bin/env Should those .py files in libpfm-4.2.0/python/src be executable or should the /usr/bin/env be removed from them? -Will ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ perfmon2-devel mailing list perfmon2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
