Hi Stephane,
Michael Petlan noticed that the page walks and cycle descriptions were swapped
for Intel Knights Landing. The patch applies to the current git repo and
builds. Would it be possible to get it patch into the upstream libpfm?
-Will
-------- Forwarded Message --------
Subject: [PATCH] libpfm4: knl page_walks umask description fix
Date: Wed, 17 May 2017 14:13:34 +0200 (CEST)
From: Michael Petlan <mpet...@redhat.com>
To: perfmon2-devel@lists.sourceforge.net
CC: wco...@redhat.com
Hi,
the umask description lines related to Intel Knights Landing page_walks
event are swapped, attached patch should fix it to match the Intel manual
(Intel Xeon Phi Processor Performance Monitoring Reference Manual, vol2).
Regards,
Michael
diff --git a/lib/events/intel_knl_events.h b/lib/events/intel_knl_events.h
index 0a69a16..4628a4f 100644
--- a/lib/events/intel_knl_events.h
+++ b/lib/events/intel_knl_events.h
@@ -300,35 +300,35 @@ static const intel_x86_umask_t knl_mem_uops_retired[]={
static const intel_x86_umask_t knl_page_walks[]={
{ .uname = "D_SIDE_CYCLES",
- .udesc = "Counts the total D-side page walks that are completed or
started. The page walks started in the speculative path will also be counted.",
+ .udesc = "Counts the total number of core cycles for all the D-side page
walks. The cycles for page walks started in speculative path will also be
included.",
.ucode = 0x100,
.uflags = INTEL_X86_NCOMBO,
},
{ .uname = "D_SIDE_WALKS",
- .udesc = "Counts the total number of core cycles for all the D-side page
walks. The cycles for page walks started in speculative path will also be
included.",
+ .udesc = "Counts the total D-side page walks that are completed or
started. The page walks started in the speculative path will also be counted.",
.ucode = 0x100 | INTEL_X86_MOD_EDGE | (1ULL << INTEL_X86_CMASK_BIT),
.modhw = _INTEL_X86_ATTR_E | _INTEL_X86_ATTR_C,
.uflags = INTEL_X86_NCOMBO,
},
{ .uname = "I_SIDE_CYCLES",
- .udesc = "Counts the total I-side page walks that are completed.",
+ .udesc = "Counts the total number of core cycles for all the I-side page
walks. The cycles for page walks started in speculative path will also be
included.",
.ucode = 0x200,
.uflags = INTEL_X86_NCOMBO,
},
{ .uname = "I_SIDE_WALKS",
- .udesc = "Counts the total number of core cycles for all the I-side page
walks. The cycles for page walks started in speculative path will also be
included.",
+ .udesc = "Counts the total I-side page walks that are completed.",
.ucode = 0x200 | INTEL_X86_MOD_EDGE | (1ULL << INTEL_X86_CMASK_BIT),
.modhw = _INTEL_X86_ATTR_E | _INTEL_X86_ATTR_C,
.uflags = INTEL_X86_NCOMBO,
},
{ .uname = "CYCLES",
- .udesc = "Counts the total page walks completed (I-side and D-side)",
+ .udesc = "Counts the total number of core cycles for all the page walks.
The cycles for page walks started in speculative path will also be included.",
.ucode = 0x300,
.modhw = _INTEL_X86_ATTR_E | _INTEL_X86_ATTR_C,
.uflags = INTEL_X86_NCOMBO | INTEL_X86_DFL,
},
{ .uname = "WALKS",
- .udesc = "Counts the total number of core cycles for all the page walks.
The cycles for page walks started in speculative path will also be included.",
+ .udesc = "Counts the total page walks completed (I-side and D-side)",
.ucode = 0x300 | INTEL_X86_MOD_EDGE | (1ULL << INTEL_X86_CMASK_BIT),
.modhw = _INTEL_X86_ATTR_E | _INTEL_X86_ATTR_C,
.uflags = INTEL_X86_NCOMBO,
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
perfmon2-devel mailing list
perfmon2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
