Hello, Finally got the event list published on the Marvell website at https://www.marvell.com/documents/hrur6mybdvk5uki1w0z7/ Moved uncore events to separate header file and requested merge. Please let me know if there are any other changes required to merge this in.
Thanks, - Shay Gal-On - -----Original Message----- From: Shay Gal-On <sga...@marvell.com> Sent: Tuesday, November 12, 2019 2:31 PM To: William Cohen <wco...@redhat.com>; eran...@gmail.com Cc: perfmon2-devel@lists.sourceforge.net Subject: Re: [perfmon2] [EXT] Re: ThunderX2 uncore events support Done, working with corp red tape to get "official" doc updated with the uncore counter info. Thanks, - Shay Gal-On - -----Original Message----- From: William Cohen <wco...@redhat.com> Sent: Tuesday, November 12, 2019 12:46 PM To: Shay Gal-On <sga...@marvell.com>; eran...@gmail.com Cc: perfmon2-devel@lists.sourceforge.net Subject: Re: [EXT] Re: [perfmon2] ThunderX2 uncore events support On 11/4/19 12:46 PM, Shay Gal-On wrote: > Hello Stephane, > > Hi Shay, How is the patch rework coming to put the events in a separate header file? > > Does this count for docs? > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_gpkulkarni_module-5Ftx2-5Fpmu_blob_master_thunderx2-2Devents.txt&d=DwIGaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=qsCxaIqWOxCmR8DpNsh72r7QMpbYQOXOXh7_B3i2sH8&m=FMKgstDjTot45w8CtkbfmT7nkXu9vIW5KsyDfi7jLZk&s=GizVDoQuQM2xt9kQp-GmOJAqI_jI9CMFloeCfmAX5d4&e= > > > If not, I can work with our legal to get something published through the > Marvell support site. It would be wise to have something on a Marvell support site even if the github link above is good enough. > > > > Will move the event descriptions as requested. > > Is it ok if I call the file > > lib/event/marvell_thunderx2_uncore_events.h instead? Are there other uncore pmus on thunderx2 that might be exposed later? Would it be reasonable to name it lib/events/arm_tx2_unc_llc_events.h? -Will > > > > Thanks, > > > > * Shay Gal-On > > > > *From:* Stephane Eranian <eran...@googlemail.com> > *Sent:* Sunday, November 3, 2019 12:51 AM > *To:* Will Cohen <wco...@redhat.com> > *Cc:* Shay Gal-On <sga...@marvell.com>; perfmon2-devel@lists.sourceforge.net > *Subject:* [EXT] Re: [perfmon2] ThunderX2 uncore events support > > > > External Email > > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > > Will, > > > > On Fri, Nov 1, 2019 at 12:01 PM Will Cohen <wco...@redhat.com > <mailto:wco...@redhat.com>> wrote: > > Hi Stephane, > > > > Would it be possible to get this patch for the Marvell ThunderX2 reviewed > and merged into the upstream libpfm? -Will > > > > I can merge the patch if: > > - the uncore events are moved into their own > lib/event/cavium_x2_unc_eventt.h file to make this cleaner > > - I have a pointer to a public document describing these llc uncore events > > > > thanks. > > > > On Thu, Oct 24, 2019 at 5:05 PM Shay Gal-On <sga...@marvell.com > <mailto:sga...@marvell.com>> wrote: > > Hello, > > > > Uncore event support for Marvell ThunderX2 was added to Linux kernel > upstream, see > https://urldefense.proofpoint.com/v2/url?u=https-3A__lkml.org_lkml_2018_11_22_513&d=DwIGaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=qsCxaIqWOxCmR8DpNsh72r7QMpbYQOXOXh7_B3i2sH8&m=FMKgstDjTot45w8CtkbfmT7nkXu9vIW5KsyDfi7jLZk&s=9kVpHpzotXf09J9h9v3vsUZ7g0n6RpO60Ao4EuEgXFc&e= > > <https://urldefense.proofpoint.com/v2/url?u=https-3A__lkml.org_lkml_2018_11_22_513&d=DwMFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=qsCxaIqWOxCmR8DpNsh72r7QMpbYQOXOXh7_B3i2sH8&m=_Ua7Ff4eypsMVn45rDcnRubawmnX5hlXhiiU3r-6MJE&s=BultQ4pTN6KaSmwr_KD012hHwZIN-zClnnuXT1D1kPA&e=> > > Please see > https://urldefense.proofpoint.com/v2/url?u=https-3A__sourceforge.net_p_perfmon2_libpfm4_merge-2Drequests_13_&d=DwIGaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=qsCxaIqWOxCmR8DpNsh72r7QMpbYQOXOXh7_B3i2sH8&m=FMKgstDjTot45w8CtkbfmT7nkXu9vIW5KsyDfi7jLZk&s=epP8bPbE12VHtNnduvc-1uzLJcsprvW3hjy3YOxC1gk&e= > > <https://urldefense.proofpoint.com/v2/url?u=https-3A__sourceforge.net_p_perfmon2_libpfm4_merge-2Drequests_13_&d=DwMFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=qsCxaIqWOxCmR8DpNsh72r7QMpbYQOXOXh7_B3i2sH8&m=_Ua7Ff4eypsMVn45rDcnRubawmnX5hlXhiiU3r-6MJE&s=GbbBT921xwetAXnj_gNFmRZZcriiBLQpOYPz1eZKagQ&e=> > to add support in libpfm. > > > > > > > > Thanks, > > > > * Shay Gal-On > > Principal Engineer, Server Processor Business Unit, Marvell > > > > > > _______________________________________________ > perfmon2-devel mailing list > perfmon2-devel@lists.sourceforge.net > <mailto:perfmon2-devel@lists.sourceforge.net> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.sourceforge.net_lists_listinfo_perfmon2-2Ddevel&d=DwIGaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=qsCxaIqWOxCmR8DpNsh72r7QMpbYQOXOXh7_B3i2sH8&m=FMKgstDjTot45w8CtkbfmT7nkXu9vIW5KsyDfi7jLZk&s=NLiNgmi5hhlPeErNL4-zTEBrV9vHAgyH5vM1E9uEPto&e= > > <https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.sourceforge.net_lists_listinfo_perfmon2-2Ddevel&d=DwMFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=qsCxaIqWOxCmR8DpNsh72r7QMpbYQOXOXh7_B3i2sH8&m=_Ua7Ff4eypsMVn45rDcnRubawmnX5hlXhiiU3r-6MJE&s=9bWLLziN6IEolUm5AUxY1q-YBiJLruZF5TmzWmeIai4&e=> > _______________________________________________ perfmon2-devel mailing list perfmon2-devel@lists.sourceforge.net https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.sourceforge.net_lists_listinfo_perfmon2-2Ddevel&d=DwIGaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=qsCxaIqWOxCmR8DpNsh72r7QMpbYQOXOXh7_B3i2sH8&m=hG7hH3zjkyWxvigvT2-yjRibntHBPz_ts8CFhBqhScc&s=c7PMdV-5Wd8n7zQqLJfvUS6M61HlspJaRrE5XWrdTbo&e= _______________________________________________ perfmon2-devel mailing list perfmon2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/perfmon2-devel