On Tue, 2007-01-09 at 02:43 -0800, Stephane Eranian wrote:
> Phil,
> 
> On Tue, Jan 09, 2007 at 10:54:07AM +0100, Philip J. Mucci wrote:
> > Stefane,
> > 
> > How did you handle the processor type detection? I had to change lots of
> > the oprofile kernel code to do this... Attached is my patch that works
> > on the PIII (and most likely MIPS). This patch is probably significantly
> > less involved that Stefanes.
> > 
> I simply extended the get_cpu_type() function by cloning what was already
> in nmi_int.c and other x86 related OProfile files. Is there another place
> that needs to be fixed?

I'm not sure about nmi_int.c, but when setting the oprofile processor
type, you have to set it to that what is listed in the events directory.
Things like 'i386/piii'. You can't use what perfmon2 uses as the pmu
name. So I have a big table in the initialization function that maps
things.

> > The one thing that's missing from Oprofile for MIPS is to use BogoMIPS
> > for MHZ. There is no MHZ in the output of /proc/cpuinfo, but bogomips is
> > as correct as can be.
> > 
> I don't know about this.
> 
> > Note there are numerous corrections for 64 bit ints and stuff.
> > 
> In the opd_perfmon.c from Will, there were a couple of LP64 vs. ILP32
> errors when setting up the PMD registers.
> 
> In the case of MIPS, are you also relying on libpfm? If so did you 
> reconcile the OProfile and libpfm event names?

I based my patch on the original patch from Will, so I don't use libpfm
at all. It still uses the oprofile event tables.

Phil


_______________________________________________
perfmon mailing list
[email protected]
http://www.hpl.hp.com/hosted/linux/mail-archives/perfmon/

Reply via email to