Also, as a signal that you're all done with addressing the reviewer's comments, you can hit the "Done" button on each of the comments, and then hit Reply on the CL page, to submit them.
On Fri, 14 Sep 2018 at 03:01, Adrian Tritschler <[email protected]> wrote: > > thanks Ivan, Matthieu. I've resubmitted. (and written myself some notes as > I go) > > On Fri, Sep 14, 2018 at 10:52 AM Ivan Vučica <[email protected]> wrote: >> >> Or better yet what Mathieu said (my response is the generic Gerrit case, not >> perkeep specific). >> >> >> On 14 September 2018 at 00:51:09, Ivan Vučica ([email protected]) wrote: >> >> IIRC, just push back into refs/for/master or whichever branch you want to >> eventually merge this into. >> >> https://gerrit-review.googlesource.com/Documentation/user-changeid.html#change-upload >> https://gerrit-review.googlesource.com/Documentation/user-upload.html#push_create >> >> e.g. >> git push ssh://sshusername@hostname:29418/projectname HEAD:refs/for/branch >> git push ssh://[email protected]:29418/kernel/common >> HEAD:refs/for/experimental >> >> Meaning “push into repo at ssh://sshusername@hostname:29418/projectname; >> take local reference HEAD and store it as refs/for/branch (or, in the latter >> case, experimental”). >> >> On 14 September 2018 at 00:48:23, ajft ([email protected]) wrote: >> >> Quick question on git & gerrit process. >> >> I think I've addressed the feedback raised, but am not sure how to resubmit. >> >> Locally fixed with "git commit --amend" (as per >> https://gerrit-review.googlesource.com/Documentation/user-changeid.html) >> >> How do i resubmit for review? >> >> thanks, >> Adrian >> -- >> You received this message because you are subscribed to the Google Groups >> "Perkeep" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "Perkeep" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Perkeep" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
