Replied there.
On Thu, Mar 28, 2019 at 3:23 PM Gina White <[email protected]> wrote: > Cool. > > I also sent out https://perkeep-review.googlesource.com/c/perkeep/+/19066 > earlier. > That change includes all the extensions that I saw listed in TestIsVideo. > > - Gina > > On Thu, Mar 28, 2019 at 3:14 PM Brad Fitzpatrick <[email protected]> wrote: > >> I just pushed >> https://github.com/perkeep/perkeep/commit/7c03aef51f6f4ed8cfe848bd0f95c48f229830d5 >> >> On Thu, Mar 28, 2019 at 3:09 PM Brad Fitzpatrick <[email protected]> wrote: >> >>> Yeah, we shouldn't be depending on the system mime.types for anything >>> important. >>> >>> We have our own mime/magic package where new signatures can be added. >>> >>> >>> On Wed, Mar 27, 2019 at 10:53 AM Gina White <[email protected]> >>> wrote: >>> >>>> Hi, I am seeing this test fail on both windows and on arch linux: >>>> >>>> --- FAIL: TestIsVideo (0.08s) >>>> search_test.go:41: IsVideo failed video=true filename=movie.mkv >>>> mimetype=application/octet-stream >>>> FAIL >>>> FAIL perkeep.org/pkg/types/camtypes 0.399s >>>> >>>> My understanding is that on windows, this more or less gets translated >>>> to a registry lookup. I haven't dug into it in detail, but suspect that it >>>> is going to be highly dependent on whether I have installed an application >>>> that registers itself as being able to handle the .mkv extension. >>>> >>>> On arch linux the problem seems to be that our code (via the golang >>>> stdlib) expects to read a mime.types file and that is not installed by >>>> default on arch linux. Their perspective is that this file is used by >>>> 'Heirloom >>>> UNIX programs', a phrase I am enjoying. >>>> >>>> I'm thinking that if this functionality is important enough to test, >>>> then perhaps perkeep should call AddExtensionType with the types it cares >>>> about. What do you all think? >>>> >>>> thanks >>>> - Gina >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Perkeep" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "Perkeep" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > -- > You received this message because you are subscribed to the Google Groups > "Perkeep" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Perkeep" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
