From 2a518b974ebb7576764abafa8e94d5c9d449ee25 Mon Sep 17 00:00:00 2001 From: Paul Howarth <p...@city-fan.org> Date: Thu, 14 Jan 2016 13:31:13 +0000 Subject: Spec clean-up
- Drop %defattr, redundant since rpm 4.4 - Prefer %global over %%define - Drop obsoletes/provides for old -tests sub-package - Flesh out buildreqs - Explicitly BR: perl-devel, needed for EXTERN.h --- perl-Readonly-XS.spec | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/perl-Readonly-XS.spec b/perl-Readonly-XS.spec index c090d8e..cdbfada 100644 --- a/perl-Readonly-XS.spec +++ b/perl-Readonly-XS.spec @@ -1,6 +1,6 @@ Name: perl-Readonly-XS Version: 1.05 -Release: 21%{?dist} +Release: 22%{?dist} Summary: Companion module for Readonly Group: Development/Libraries License: GPL+ or Artistic @@ -9,7 +9,14 @@ Source0: http://search.cpan.org/CPAN/authors/id/R/RO/ROODE/Readonly-XS-%{version Patch0: Readonly-XS-1.05-prereq.patch Patch1: Readonly-XS-1.05-interpreter.patch BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu) -# Build +# Build (perl-devel split from main perl package at F-7) +BuildRequires: coreutils +BuildRequires: findutils +BuildRequires: make +BuildRequires: perl +%if 0%{?fedora} > 6 || 0%{?rhel} > 5 +BuildRequires: perl-devel +%endif BuildRequires: perl(ExtUtils::MakeMaker) # Module BuildRequires: perl(Carp) @@ -24,10 +31,6 @@ Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) Requires: perl(Carp) Requires: perl(Readonly) >= 1.02 -# Obsolete/provide old -tests subpackage (can be removed in F19 development cycle) -Obsoletes: perl-Readonly-XS-tests < %{version}-%{release} -Provides: perl-Readonly-XS-tests = %{version}-%{release} - # Don't provide the private XS.so() lib %{?perl_default_filter} @@ -46,7 +49,7 @@ scalar variables. # Avoid doc-file dependencies from tests if we don't have %%perl_default_filter %global perl_reqfilt /bin/sh -c "%{__perl_requires} | grep -Fvx 'perl(Test::More)'" -%define __perl_requires %{perl_reqfilt} +%global __perl_requires %{perl_reqfilt} %build perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}" @@ -66,13 +69,20 @@ make test rm -rf %{buildroot} %files -%defattr(-,root,root,-) %doc README Changes t/ %{perl_vendorarch}/auto/Readonly/ %{perl_vendorarch}/Readonly/ -%{_mandir}/man3/Readonly::XS.3pm* +%{_mandir}/man3/Readonly::XS.3* %changelog +* Thu Jan 14 2016 Paul Howarth <p...@city-fan.org> - 1.05-22 +- Spec clean-up: + - Drop %%defattr, redundant since rpm 4.4 + - Prefer %%global over %%define + - Drop obsoletes/provides for old -tests sub-package + - Flesh out buildreqs +- Explicitly BR: perl-devel, needed for EXTERN.h + * Thu Jun 18 2015 Fedora Release Engineering <rel-...@lists.fedoraproject.org> - 1.05-21 - Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild -- cgit v0.11.2 http://pkgs.fedoraproject.org/cgit/perl-Readonly-XS.git/commit/?h=master&id=2a518b974ebb7576764abafa8e94d5c9d449ee25 -- Fedora Extras Perl SIG http://www.fedoraproject.org/wiki/Extras/SIGs/Perl perl-devel mailing list perl-devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/perl-devel@lists.fedoraproject.org