Notification time stamped 2019-10-24 15:08:19 UTC

From ea364fe04b7a831aa4adf7f2bd86839ba6fdd432 Mon Sep 17 00:00:00 2001
From: Paul Howarth <[email protected]>
Date: Oct 24 2019 15:07:20 +0000
Subject: Tweak for EPEL-8 build


- Specify all dependencies
- Avoid need to bootstrap with Types::Standard on EPEL
- Use %{make_build} and %{make_install}
- Fix permissions verbosely
- Make %files list more explicit

---

diff --git a/perl-Type-Tie.rpmlintrc b/perl-Type-Tie.rpmlintrc
new file mode 100644
index 0000000..e997baa
--- /dev/null
+++ b/perl-Type-Tie.rpmlintrc
@@ -0,0 +1,2 @@
+from Config import *
+addFilter("spelling-error %description -l en_US (coercions|ttie) -> ")
diff --git a/perl-Type-Tie.spec b/perl-Type-Tie.spec
index 80d514f..43f2568 100644
--- a/perl-Type-Tie.spec
+++ b/perl-Type-Tie.spec
@@ -1,50 +1,61 @@
+# Run extra test
+%if ! (0%{?rhel})
+%bcond_without perl_Type_Tie_enables_extra_test
+%else
+%bcond_with perl_Type_Tie_enables_extra_test
+%endif
+
 Name:           perl-Type-Tie
 Version:        0.014
-Release:        4%{?dist}
+Release:        5%{?dist}
 Summary:        Tie a variable to a type constraint
 # cf. README
 License:        GPL+ or Artistic
 URL:            https://metacpan.org/release/Type-Tie
 Source0:        
https://cpan.metacpan.org/authors/id/T/TO/TOBYINK/Type-Tie-%{version}.tar.gz
 BuildArch:      noarch
-
-BuildRequires:  %{__perl}
-BuildRequires:  %{__make}
-
-BuildRequires:  perl-interpreter >= 0:5.008005
+# Build
+BuildRequires:  coreutils
+BuildRequires:  make
 BuildRequires:  perl-generators
-
+BuildRequires:  perl-interpreter >= 0:5.008005
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
+BuildRequires:  sed
+# Module
+BuildRequires:  perl(B)
 BuildRequires:  perl(Carp)
+BuildRequires:  perl(Data::Dumper)
 BuildRequires:  perl(Exporter::Tiny) >= 0.026
-BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(Hash::FieldHash)
-BuildRequires:  perl(Moo)
+BuildRequires:  perl(overload)
+BuildRequires:  perl(Scalar::Util)
+BuildRequires:  perl(strict)
 BuildRequires:  perl(Tie::Array)
 BuildRequires:  perl(Tie::Hash)
 BuildRequires:  perl(Tie::Scalar)
-BuildRequires:  perl(strict)
 BuildRequires:  perl(warnings)
-
-# Tests:
-%if !%{defined perl_bootstrap}
-# Build-cycle: perl-Type-Tiny → perl-Type-Tie
-BuildRequires:  perl(Types::Standard)
-%endif
-BuildRequires:  perl(Moose::Util::TypeConstraints)
-BuildRequires:  perl(MooseX::Types::Moose)
+# Test Suite
+BuildRequires:  perl(constant)
 BuildRequires:  perl(Test::Fatal)
 BuildRequires:  perl(Test::More) >= 0.96
 BuildRequires:  perl(Test::Requires)
-BuildRequires:  perl(Try::Tiny)
-BuildRequires:  perl(constant)
-
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo 
$version))
-
-# perl-generators fails to detect this
+# Optional Tests
+BuildRequires:  perl(Moo)
+BuildRequires:  perl(Moose::Util::TypeConstraints)
+BuildRequires:  perl(MooseX::Types::Moose)
+%if !%{defined perl_bootstrap} && %{with perl_Type_Tie_enables_extra_test}
+# Build-cycle: perl-Type-Tiny → perl-Type-Tie
+BuildRequires:  perl(Types::Standard)
+%endif
+# Dependencies
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+Requires:       perl(B)
 Requires:       perl(Data::Dumper)
+Requires:       perl(Hash::FieldHash)
+Requires:       perl(overload)
 
 %description
-This module exports a single function: ttie. ttie ties a variable to a
+This module exports a single function: ttie, which ties a variable to a
 type constraint, ensuring that whatever values stored in the variable
 will conform to the type constraint. If the type constraint has
 coercions, these will be used if necessary to ensure values assigned to
@@ -53,29 +64,37 @@ the variable conform.
 %prep
 %setup -q -n Type-Tie-%{version}
 
-# Remove bundled stuff
-%{__rm} -r inc/
+# Remove bundled modules Test::Fatal, Test::Requires and Try::Tiny
+rm -r inc/
 sed -i -e '/^inc\/.*$/d' MANIFEST
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
-%{__make} %{?_smp_mflags}
+perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
+%{make_build}
 
 %install
-%{__make} pure_install DESTDIR=$RPM_BUILD_ROOT
-
-%{_fixperms} $RPM_BUILD_ROOT/*
+%{make_install}
+%{_fixperms} -c %{buildroot}
 
 %check
-%{__make} test
+make test
 
 %files
-%doc Changes README
 %license COPYRIGHT LICENSE
-%{perl_vendorlib}/*
-%{_mandir}/man3/*
+%doc Changes README
+%{perl_vendorlib}/Type/
+%{_mandir}/man3/Type::Nano.3*
+%{_mandir}/man3/Type::Tie.3*
 
 %changelog
+* Thu Oct 24 2019 Paul Howarth <[email protected]> - 0.014-5
+- Tweak for EPEL-8 build
+  - Specify all dependencies
+  - Avoid need to bootstrap with Types::Standard on EPEL
+  - Use %%{make_build} and %%{make_install}
+  - Fix permissions verbosely
+  - Make %%files list more explicit
+
 * Fri Jul 26 2019 Fedora Release Engineering <[email protected]> - 
0.014-4
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
 


        
https://src.fedoraproject.org/rpms/perl-Type-Tie/c/ea364fe04b7a831aa4adf7f2bd86839ba6fdd432?branch=epel8
_______________________________________________
perl-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to