On 31/12/03 9:45 pm, D.Kreft <[EMAIL PROTECTED]> wrote: > On Wed, 31 Dec 2003, Chris Ridd did scribble: > >> There's at least one way where these methods return a non-object. Mostly >> they call _error() to set an error code in a message object, but this isn't >> always true - if $ldap->socket fails the integer LDAP_SERVER_DOWN is >> returned (NB this is 81, so seems to be what you're getting) >> >> This is probably not right, as it is inconsistent. > > I would agree. The inconsistency is made even more odious by a lack of > documentation indicating the potential for non-object return values.
Yes, it is probably just a coding mistake. >> I suspect the socket failure case in _sendmesg() should be something like: >> >> my $socket = $ldap->socket >> or return _error($ldap, $mesg, LDAP_SERVER_DOWN, "$!"); > > *nod* Any chance someone can make this happen? :-) I've just committed this change into CVS, but it would be good if you (or anyone else who can reproduce this problem) could test it... Cheers, Chris
