On 31 May 2004, at 22:00, Peter Marschall wrote:
Hi Graham, hi Chris, hi list,
I shouldn't have begged for a new relaese to be cut so quickly.
Here's a set of new patches against Authen::SASL.
The first one - Authen-SASL-2.08-import.patch - uses the import routine to
select the plugins and/or their order to be used in Authen::SASL.
This patch has been tested during the creation of the patch that led to
Authen::SASL 2.08.
I like the idea but,
In your implementation you forgot to shift the fist argument from @_, so Authen::SASL would get pushed into the array and it should not.
It could be argued that if none of the mentioned packages are loadable then the import should die, not just silently continue to use the default.
It makes the use line very wordy, I would suggest that any argument passed that does not contain :: is prefixed with Authen::SASL:: by the code.
The other one - Authen-SASL-2.08-digestmd5.patch - adds the possibility to
authenticate as one person for another person using the authname callback (as
in Authen::SASL::Perl::Plain) to Authen::SASL::Perl::DIGEST_MD5.pm.
Unfortunately I have not had the time to test this patch yet, but if I
interpreted the RFC correctly it should work ;-)
Thanks, Graham.
