Daniel Stutz wrote:
Chris Ridd wrote:
The only difference is in the field name, and as it is not part of the encoding I see no particular reason to change anything.
The field name is part of the _decoding_. That means the attribute "response" is now "responseValue" in the Message object and the accessor for "response" is returning "undef".

What I was trying to say was that the field name is irrelevant to the bytes ("the encoding") on the wire. You're right about it being relevant to code accessing the field.

I've taken a quick look at both the 0.36 code and what's in svn, but it does all look internally consistent. ASN.pm calls the thing "response", and the only code I can see that accesses that kind of message (LDAP/Extension.pm) also calls it "response".

The only thing I can imagine might be a potential problem is that the IntermediateResponse sequence uses responseName/responseValue, so if there's code trying to deal with both in the same way, that will fail. Is there such code?

Sorry if I'm being dense, but I don't see any other problem :-(

Cheers,

Chris

Reply via email to