On 8 Mar 2010, at 09:00, Etienne Bagnoud wrote: > On Fri, 05 Mar 2010 18:11:38 +0000 > Chris Ridd <chrisr...@mac.com> wrote: > >> You should also add an OID to Net::LDAP::Constant so that callers can >> easily test for this extension's presence in the root DSE. >> > > Is that ok ? > > --- Constant.pm 2010-03-08 09:32:35.465009668 +0100 > +++ LDAP/Constant.pm 2010-03-08 09:32:04.205522371 +0100 > @@ -592,6 +592,10 @@ > > Indicates that the server supports the "Who am I?" extension > (draft-zeilenga-ldap-authzid-09) > +=item LDAP_EXTENSION_REFRESH (1.3.6.1.4.1.1466.101.119.1) > + > +Indicates that the server supports the Refresh extension (RFC 2589) > + > =back > > =head2 Feature OIDs
I think you need a blank line before the new =item line, at least just for readability. I also note the reference to authzid-09 in the diff context is outdated and should be RFC 4532. Otherwise it looks good to me! Cheers, Chris
