Hi,

I propose following patch to solve the bad behaviour of Constant.t test
script.
I supply the EBCDIC value for pound character.

____________________________________________________________

--- Constant.t.orig     Sat Jun  1 19:03:16 2002
+++ Constant.t  Fri Jun 14 10:22:23 2002
@@ -56,7 +56,11 @@
 my $parent_rfc1149 =
   'A Standard for the Transmission of IP Datagrams on Avian Carriers';
 # Check that 8 bit and unicode names don't cause problems.
+if (ord('A') eq 193) {  # EBDDIC platform
+my $pound = chr 177; # A pound sign. (Currency)
+} else { # ASCII platform
 my $pound = chr 163; # A pound sign. (Currency)
+}
 my $inf = chr 0x221E;
 # Check that we can distiguish the pathological case of a string, and the
 # utf8 representation of that string.

________________________________________________________


With this patch test result is as follows, 9 fails over 51 tests.
What do think about this patch ?
To locate remaining problems I found Constant.t complicate to work with it,
can somebody help me ?
Here the messages that are printed when when running Constant.t:

.../lib/ExtUtils/t/Constant.............%  CFE1111[WARNING]: ExtTest.xs /
59: statement is unreachable
        if (utf8) {
        ^
%  CFE1111[WARNING]: ExtTest.xs /     74: statement is unreachable
      break;
      ^
%  CFE1111[WARNING]: ExtTest.xs /     93: statement is unreachable
        if (utf8) {
        ^
%  CFE1111[WARNING]: ExtTest.xs /    108: statement is unreachable
      break;
      ^
%  CFE1111[WARNING]: ExtTest.xs /    127: statement is unreachable
        if (utf8) {
        ^
%  CFE1111[WARNING]: ExtTest.xs /    142: statement is unreachable
      break;
      ^
%  CFE1111[WARNING]: ExtTest.xs /    161: statement is unreachable
        if (utf8) {
        ^
%  CFE1111[WARNING]: ExtTest.xs /    176: statement is unreachable
      break;
      ^
%  CFE1111[WARNING]: ExtTest.xs /    938: statement is unreachable
      break;
      ^
%  CFE1111[WARNING]: ExtTest.xs /    941: statement is unreachable
      break;
      ^
%  CFE1111[WARNING]: ExtTest.xs /    944: statement is unreachable
      break;
      ^
%  CFE1111[WARNING]: ExtTest.xs /    947: statement is unreachable
      break;
      ^
%  CFE1111[WARNING]: ExtTest.xs /    950: statement is unreachable
      break;
      ^
%  CFE1111[WARNING]: ExtTest.xs /    953: statement is unreachable
      break;
      ^
%  CFE1111[WARNING]: ExtTest.xs /   1011: statement is unreachable
      break;
      ^
 
Backslash found where operator expected at ExtTest.xs line 6, near
""\x{BC}"\"
        (Missing operator before \?)
Backslash found where operator expected at ExtTest.xs line 7, near
""\x{BC}"\"
        (Missing operator before \?)
Backslash found where operator expected at ExtTest.xs line 8, near
""\x{BC}"\"
        (Missing operator before \?)
Backslash found where operator expected at ExtTest.xs line 9, near
""\x{BC}"\"
        (Missing operator before \?)
Backslash found where operator expected at ExtTest.xs line 10, near
""\x{BC}"\"
        (Missing operator before \?)
Backslash found where operator expected at ExtTest.xs line 10, near ")\"
        (Missing operator before \?)
Backslash found where operator expected at ExtTest.xs line 15, near
""\x{BC}"\"
        (Missing operator before \?)
Backslash found where operator expected at ExtTest.xs line 19, near
""\x{BC}"\"
        (Missing operator before \?)
parse error at ExtTest.xs line 6, near ""\x{BC}"\"
Execution of ExtTest.xs aborted due to compilation errors.
FAILED tests 32-33, 38-42, 45-46
        Failed 9/51 tests, 82.35% okay

Reply via email to