On Wed, Aug 29, 2001 at 11:16:44AM -0400, Joe McMahon wrote:
> Here's a patch for op/avhv.t ro remove the 'print "not "' in bleadperl.
> You wanted us to send them to you, not to p5p, right?
Ayep. Thanks! A few critiques...
First, use unified diff (diff -u). Easier for me to read. Sun's diff
probably doesn't have it, so get a copy of GNU diff (it's not
critical).
> + sub ok {
> + my ($msg,$ok) = reverse @_;
Ummm... reverse?
> + $ok
> + ? print "ok $test\n"
> + : print "not ok $test # $msg\n";
Ooooh, I like that construct. Much simpler than the one I put into
perlhack.
But do this instead.
: print "not ok $test - $msg\n";
Stuff after a # in a test can have special meaning.
Also, add in the diagnostic print, so people know where the failure
occured.
printf "# Failed test at line %d\n", (caller)[2];
> ! ok(!%$avhv,"single scalar context");
Use a bit more whitespace between the test and the name. Easier on
the eyes.
ok( !%$avhv, 'single scalar context' );
Other than that, looks good. Just put in those changes and resubmit it.
--
Michael G. Schwern <[EMAIL PROTECTED]> http://www.pobox.com/~schwern/
Perl6 Quality Assurance <[EMAIL PROTECTED]> Kwalitee Is Job One
Follow me to certain death!
http://www.unamerican.com/
