On Tue, Aug 28, 2001 at 08:57:45PM -0400, Michael G Schwern wrote:
> On Tue, Aug 28, 2001 at 07:56:30PM -0400, Kirrily 'Skud' Robert wrote:
> >                 Term::ReadKey     0%  
> 
> This might be helped by doing:
> 
> --- Coverage.orig       Tue Aug 28 20:39:04 2001
> +++ lib/Pod/Coverage.pm Tue Aug 28 20:39:42 2001
> -        return unless $text =~ /(.*)/;
> +        return unless $text =~ /^\s*(\S+)/;

Applied, thanks.

> Better.  If we skip bootstrap...

Applied too.  Patches are so much fun :)

> Here's another suggestion.  You could check to see if the module ISA
> Exporter and only consider the exportable functions for POD coverage.
> UNIVERSAL::exports will tell you what's exportable.
> 
> If you could feed Pod::Coverage a code ref to evaluate what's private
> and what's not...
>
> [example code]                                  
>
> private_check would be called for anything not explicitly declared
> private.
>                                                                                      
>                   
> Or provide this as a switch.
>                                                                                      
>                   
>     Pod::Coverage->new(package => "Foo", only_exportable => 1);
>                                                                                      
>                   
> private_check would be useful on it's own, though.

Yes, it would.  I like both, shall hack it in later on today.  Thanks
for the input.

I've placed a snapshot based on what I was able to sneak in this
morning online as
http://unixbeard.net/~richardc/lab/Pod-Coverage/Pod-Coverage-0.05_01.tar.gz

It's now using Pod::Find, and takes optional C<debug> and C<pod_from>
arguments.  I rejigged the subroutine identification to be part of the
pod parser too, so it all lives in one place.

Oddly Skud's script now segfaults under 5.6.1 while requiring the
second module it checks. (on my box this is Archive::Tar, after
Algorithm::MarkovChain) It didn't before so it's either something that
Pod::Find does or I subtly broke something else.  Will pore over the
diffs when I get a chance.

-- 
Richard Clamp <[EMAIL PROTECTED]>
 happy people have no stories

Reply via email to