On Tue, Oct 30, 2001 at 06:09:55AM +0200, Jarkko Hietaniemi wrote:
> Thanks, applied. Though I still think someone should go in with a
> pitchfork and clean out kill_perl.t, sorting the tests to other test
> script. 95% of it doesn't belong there. "Crashes Perl (or Used To)"
> is not a really useful classifying criterion, it's about as useful as
> "the number of characters in the test is divisible by 73".
Except that !(length $test % 73) doesn't cause the rest of the tests to
not run (or perhaps crash Windows).
> The new added test is, for example, most likely prime op/pat
> material.
Yes, it is. However as the bug is still in flux, having flip-flopped
between working and not working the last two weeks, I don't want to
start making op/pat.t abort just yet.
kill_perl.t is a dumping ground, but when you want to write a quick
test it's nice to have a heap to throw it onto. Better that than
chasing a bug for two years because nobody wanted to write a proper
test for it.
But, like any compost heap, it needs turning over once in a while. My
pitchfork is currently poking at perlbug's bottom. If anyone wants to
take a stab at dusting off kill_perl, first pass should probably be to
remove stuff that never actually killed perl (from when it was
t/op/misc.t).
1) Start at the top of the list (presumably those are the oldest).
2) Run the test against older perls (like 5.004), see if it causes
a segfault.
3a) If not, move it to the appropriate place.
3b) If so, and it was a really old perl, move it.
3c) If so, and it was a recent perl, leave it.
I suspect the majority will turn out to not be segfaulting on anything
like a modern perl.
--
Michael G. Schwern <[EMAIL PROTECTED]> http://www.pobox.com/~schwern/
Perl6 Quality Assurance <[EMAIL PROTECTED]> Kwalitee Is Job One
Let's leave my ass out of this, shall we?
