On Sunday 16 December 2001 02:10, Gerrit P. Haase wrote:

Thanks for the report.

> ../lib/ExtUtils/MM_Cygwin.............#     Failed test
> (../lib/ExtUtils/MM_Cygwin.t at line 73) #                   undef
> #     doesn't match '(?-xism:could not locate your pod2man)'
> #     Failed test (../lib/ExtUtils/MM_Cygwin.t at line 75)
> #                   'POD2MAN_EXE = /usr/bin/pod2man
> #     POD2MAN = $(PERL) -we '%m=@ARGV;for (keys %m){' \
> #     -e 'next if -e $$m{$$_} && -M $$m{$$_} < -M $$_ && -M $$m{$$_} < -M
> "";' \ #     -e 'print "Manifying $$m{$$_}\n"; $$m{$$_} =~ s/::/./g;' \
> #     -e 'system(qq[$$^X ].q["-I$(PERL_ARCHLIB)" "-I$(PERL_LIB)"
> $(POD2MAN_EXE) ].qq[$$_>$$m{$$_}])==0 or warn "Couldn\047t install
> $$m{$$_}\n";' \ #     -e 'chmod(oct($(PERM_RW))), $$m{$$_} or warn "chmod
> $(PERM_RW) $$m{$$_}: $$!\n";}' #
> manifypods : pure_all foo
> #       noecho$(POD2MAN) \
> #       foo \
> #       1'
> #     doesn't match '(?-xism:POD2MAN_EXE = -S pod2man)'
> # Looks like you failed 2 tests of 17.

What happens if you apply this patch and run it?  It seems to me it'll 
generate a more reliable failure, which is what the test is supposed to catch.

-- c

--- lib/ExtUtils/~MM_Cygwin.t   Sun Dec 16 11:02:04 2001
+++ lib/ExtUtils/MM_Cygwin.t    Sun Dec 16 11:07:31 2001
@@ -70,11 +70,16 @@
 $args->{MAN3PODS} = { foo => 1 };
 my $out = tie *STDOUT, 'FakeOut';
 my $res = $args->manifypods();
-like( $$out, qr/could not locate your pod2man/,
-       '... should warn if pod2man cannot be located' );
-like( $res, qr/POD2MAN_EXE = -S pod2man/,
-       '... should use default pod2man target' );
-like( $res, qr/pure_all.+foo/, '... should add MAN3PODS targets' );
+
+{
+       # try to trip warning on line 53
+       local *MM::perl_script = sub { return };
+       like( $$out, qr/could not locate your pod2man/,
+               '... should warn if pod2man cannot be located' );
+       like( $res, qr/POD2MAN_EXE = -S pod2man/,
+               '... should use default pod2man target' );
+       like( $res, qr/pure_all.+foo/, '... should add MAN3PODS targets' );
+}
 
 $args->{PERL_SRC} = File::Spec->updir;
 $args->{MAN1PODS} = { bar => 1 };

Reply via email to