Op een zonnige zomerdag (Friday 27 June 2003 20:26), schreef John Peacock:

> Abe Timmerman wrote:
> > T::S::S::Hardlink uses *all* of the source directory, so if you are using
> > a working copy (under version control) the MANIFEST check will report all
> > .svn stuff in the report. I'd use rsync on local directories (resulting
> > in something like):
> >
> >     rsync -a --delete --exclude '.svn' working_dir/. .
> >
> > This can be configured from 'configsmoke.pl' (Just make sure that the
> > rsync source ends with a slash [or slash-dot].)
>
> That's a better way to go then.  However, I just tried it and
> configsmoke.pl doesn't quote the rsync options properly, so the --exclude
> option is ignored (and the .svn files copied anyway).  I'll try and fix
> that and send you a patch.

It would be nice to be able to have quoted arguments, although I cannot see 
any reason for it to go wrong...

Okay, now I see, you have just found an error in F<configsmoke.pl> (patch 
below) I'll try and put a new release on CPAN this weekend.

Please change 'opt' to 'opts' in smokecurrent_config

Here's the patch to prevent that from happening again:

Index: configsmoke.pl
===================================================================
--- configsmoke.pl      (revision 186)
+++ configsmoke.pl      (working copy)
@@ -208,7 +208,7 @@
         alt => [ ],
         dft => whereis( 'rsync' ),
     },
-    opt => {
+    opts => {
         msg => 'Which arguments should be used for rsync?',
         alt => [ ],
         dft => '-az --delete',
@@ -644,7 +644,7 @@
         $arg = 'rsync';
         $config{ $arg } = prompt( $arg );

-        $arg = 'opt';
+        $arg = 'opts';
         $config{ $arg } = prompt( $arg );

         last SYNCER;

Good luck,

Abe
-- 
We might as well document that in future sort() in scalar context *may*
make flying pigs in pink tutus spring forth from one's nostrils, too :-)
For 5.8.0 I'm happy just to document the current behaviour.
                                   -- Jarkko Hietaniemi on p5p @ 2002-06-12

Reply via email to