On Tue, Mar 08, 2005 at 11:33:30AM -0500, Mark Stosberg wrote:
> > I'd make life simpler and dump the shell scripts, see the note about
> > cross-platform compatibility below.
> 
> The philosophy behind allowing both is to have a low barrier to entry
> for people submitting tests. Better to have tests in shell then no tests
> at all. 

That may be true, but you're coding yourself into a compatibility wall.

Hmmm.  No reason the Perl tests couldn't be as simple as the shell tests.
I might submit a conversion.  Maybe I'll get around to finally making
ExtUtils::Command useful.


> > PS  I took a look at one of the Perl tests (pull.pl) and its
> > needlessly Unix-centric making lots of shell calls which can easily be
> > done with Perl, particularly rm -rf and mkdir -p (File::Path).  Best
> > to make it cross-platform as early as possible, it sucks to bolt it on
> > later.
> 
> I'll look into that refactor. Curiously, no one has complained about
> this so far. I suspect that although it's used on lots of platforms,
> the people who run the test suite may be Unix-centric bunch right now. 

No where in the install documentation is "make test" mentioned so I suspect
most people aren't running then.


> > PPS  You're suspiciously lacking in a README or INSTALL document.  I
> > know its probably buried somewhere in the manual/ directory but still
> > its the first place many people look.
> 
> You are right. I'll work on that. 

Thanks.

Reply via email to