On 18/09/06, Adrian Howard <[EMAIL PROTECTED]> wrote:

On 17 Sep 2006, at 23:25, Fergal Daly wrote:
[snip]
> So while I don't think I'd vote for stopping the install because of an
> expected pass, I don't think it's ever a good sign. The idea of
> something working "better" than than the author expected is a bit
> dubious.
[snip]

I'm not so sure about that. One use case for TODO I see a fair amount
is as a marker for a failure that isn't under the control of the author

{
   local $TODO = "damn that third party Fribble module - see RT#12455";
   ok( $o->fribble, "fribbled" );
}

where a succeeding todo test is almost always a good sign.

But there's nothing here for the author to do so it should not  be marked TODO.

This should be a skip wrapped in something to test if the installed
version of Fribble works or not. Otherwise, if $o->fribble starts
failing because it's genuinely broken, this becomes a false positive
(which is the worst thing you can have from a test),

F

Reply via email to