Eric Wilhelm wrote: > I'm still confused about where these two bits are going. > > Ovid: > > Thanks for reminding me. Another bit of meta-information that > > should be optionally supported in the TAP YAML output is "duration". > > Michael: > >it would be nice if we could get the original > > run time of the tests. Duration can be calculated from that. > > What is "run time"? The time it takes for each test to run?
Sorry, I meant the time the test was run. In this case I was referring to the test suite as a whole, but the same thing applies to the individual test files. >>> What's that calculation look like? > > Are we talking about $harness_end - $harness_start ? Yeah. Or $stream_end - $stream_start >>> From what I've seen, we >>> currently only have the harness start/end times. >> Yeah, it's basically just doing a time() before the main runtests() >> and then again after it. >> ...But Smolder can only use the version of TAP ... >> ...there is no such information currently given. > > Isn't Smolder reading the meta.yml file from the archive? It is currently because there is nothing else. But some folks want a way to merge mutiple TAP documents into a single TAP document (via grouping or levels) so that you could have a test run where each individual test file produces TAP and then the harness can aggregate those and spit out on final TAP document. This final doc would also contain meta information about the test run (start and end times, etc). > I'm not particularly concerned about where $test_start{"foo.t"} and > $test_end{"foo.t"} are written (in the tap stream with YAML or in > meta.yml or on a bit of parchment) as long as we keep in mind that > tests may run simultaneously. I don't really care either. Just as long as I can get to the information. I'm not a big fan of multiple TAP docs merged together since I think it makes it overly complicated. But if that's the way things go, I can work with that. But if more folks want this meta information about the test run then maybe the harness could generate that meta.yml file for us and TAP::Harness::Archive can go into obscurity :) > > harness_time: [13:01.00, 13:02.30] > test_times: > foo: [13:01.01, 13:01.08] > bar: [13:01.01, 13:02.05] > baz: [13:01.08, 13:02.30] > > (pretend I typed valid datetimes and YAML) That looks good to me. And it's something that would be a little difficult for TAP::Harness::Archive to do without getting in the way of other subclasses, so either TAP::Harness::Aggregator needs to provide methods to get to that data or TAP::Harness needs to generate the meta.yml file. -- Michael Peters Developer Plus Three, LP