On Mon, Nov 12, 2007 at 10:53:42PM +0100, A. Pagaltzis wrote: > * Thomas Klausner <[EMAIL PROTECTED]> [2007-11-12 21:10]: > > The metric will be called prereq_matches_use and shall check if > > all the modules used in a dist are also listed as a prereq. > > (prereq is either gatherd directly from Meta.YMLs 'requires', > > by parsing Build.PL or Makefile.PL) > > This results in: Of 12039 dists, 5419 have missing deps > If a sizable fraction of these are in fact valid hits and not > just false negatives due to the trickiness of the problem, then > I would say the metric is direly needed!
I bet most of them are things like: " I need Foo::Bar and Baz::Barf. Foo::Bar requires Baz::Barf so I don't need to declare it. " This is an error, because the next version of Foo::Bar might drop that pre-requisite by, eg, implementing the functionality itself or changing to use something else. and: " Foo::Bar is in distribution AUTHOR/Foo-Bar which also contains Foo::Bar::Baz, so I only need to declare one of them to get both. " This is also an error, as Foo::Bar::Baz might be moved into a seperate distribution at some point in the future, or its functionality might be folded into Foo::Bar. I approve of this kwalitee metric and would like to subscribe to its newsletter^W^W^W^Wbe told which of my modules are broken. -- David Cantrell | top google result for "internet beard fetish club" One person can change the world, but most of the time they shouldn't -- Marge Simpson