On Mon, Mar 3, 2008 at 2:04 PM, Michael G Schwern <[EMAIL PROTECTED]> wrote: > > * parsing for error messages from code like "use 5.008" or from "our" > > being used in $VERSION strings prior to 5.005 > > It's that last one that concerns me, it's a bit heuristicy and I've been > things be declared NA that should have alerted the author to a backwards > compat problem.
Back before you declared 5.005 to be dead, Slaven Rezic created a lot of chaos with FAIL reports from 5.005_05 when Makefile.PL or Build.PL didn't have "use 5.006" and then ExtUtils::MakeMaker or Module::Build tried to eval an "our $VERSION" line from a .pm file. Usually, the complaints were from authors who had put "use 5.006" in their pm file, but hadn't done so in their Makefile.PL. That's not backwards compatible, true, but since we're talking about 5.005, authors were pretty annoyed at being hassled by someone smoke testing an ancient version of Perl, so I opted to add the NA heuristic instead. The error message parsing is fairly specific to the error message generated from ExtUtils::MM_Unix::parse_version and the corresponding routine in Module::Build, so as a heuristic goes, I don't think it should throw too many false positives. David
