On Mon, Sep 22, 2008 at 03:40:17PM +0300, Shlomi Fish wrote:

> My suggestion for resolving this is to modify the smoking modules so, after 
> the archive is unpacked (with a proper umask and arguments to tar), they will 
> traverse the directory tree and look for any world-writable files. If any are 
> found, they will report the smoking of the module as "FAIL", and delete the 
> unpacked directory tree, without doing the "perl Makefile.PL/Build.PL ..." 
> dance.
>
> Now I volunteer to implement this.

If you do implement this, it shouldn't be the default.  Spurious
failures are annoying.  And remember, not everyone creates their
tarballs on a platform to which Unix permissions map well.  eg, Windows
users.

-- 
David Cantrell | Official London Perl Mongers Bad Influence

    I caught myself pulling grey hairs out of my beard.
    I'm definitely not going grey, but I am going vain.

Reply via email to