On Mon, Dec 21, 2009 at 11:19 PM, Chris 'BinGOs' Williams
<ch...@bingosnet.co.uk> wrote:
> On Mon, Dec 21, 2009 at 04:15:22PM -0500, David Golden wrote:
>> You need to be asking on cpan-testers-discuss.  Copying that list now.
>>
>> -- David
>>
>> On Mon, Dec 21, 2009 at 4:02 PM, Joshua ben Jore <twi...@gmail.com> wrote:
>> > The CPAN smokers regularly spit back UNKNOWN results where the text of
>> > the error is:
>> >
>> > ?? ??Output from '/usr/bin/make':
>> >
>> > ?? ??make: *** No targets specified and no makefile found. ??Stop.
>> >
>> > One example is 
>> > http://www.nntp.perl.org/group/perl.cpan.testers/2009/07/msg4616138.html
>> > but there are many, many others. Does anyone know what's going on
>> > here?
>> >
>> > Josh
>> >
>
> Ran out of diskspace I would guess.

The just-released EU::MM 6.56 repeats this pattern frequently:

    open my($fh), '>', ...
        or croak("Can't open ... for writing: $!");
    ...
    print $fh ...; # <<< no error checking
    close $fh ...; # <<< no error checking

Grepping for code:

    egrep -rnH 'print '\\'$[^ ;]+ ' ExtUtils-MakeMaker-6.56

Where is EU::MM's version control? I'd like to submit a patch adding a bunch of:

    or croak("Can't write '$fn': $!");

Josh

Reply via email to