I've been doing a lot of work with listviews recently. I was pretty sure
I'd identified a bug with the Select method, but can't reproduce it any
more. While looking at that I added some functionality to my own copy of
Listview.xs: Select(-1) to select all items in the list and an
additional Deselect() method (for use when the list is in multiselect
mode). The problem of adding functionality to an existing method is that
you run the risk of breaking somebody else's code and the problem of
adding methods is, as Jez White suggested, you bloat the module with
"selfish" code (by the way, Jez, I fully agree with your comments and
also with Joe's reminder of the importance of documentation).

In my opinion, some kind of peer review would be useful before changing
too much (for example, would a Selectall() method be preferable to the
Select(-1) form--and is the new functionality really necessary at all?)
Perhaps the active developers already do this? And what about additions
from minor developers, such as me? I don't have write access to the CVS
repository (and really don't feel confident enough to submit any code
without such a peer review anyway). How is a good way to make
suggestions like this? Through Tracker/Feature Request perhaps?

Glenn 2



Reply via email to