2006/3/16, Robert May <[EMAIL PROTECTED]>: > Many thanks for the large amount of input. I've spoken with Jeremy > during the day, and I am going to back out your changes from the CVS > repository, and re-enter them in a more controlled fashion. I have a > number of reasons for doing this, but they boil down to: > > (1) I'd like a number of commits, splitting the commits by functionality > so that it's easier to see what changes are related (I can see at least > 3 separate commits: DrapDrop functionality, CustomDraw functionality and > the rest of your changes).
Sure. Note that DrapDrop worked before also. I only introduced a new object which is created by the event to better pick up the point and files. > (2) I want to review the the changes: For example I already have a > re-work of the DrapDrop functionality that I did some time ago (if you > look in the RFC section on Sourceforge you'll see this is a feature > request that I have assigned to myself, which means that I'm working on > it), and I'd like to implement a merge of my ideas with yours, along > with better separating the functionality. I'll raise separate mails on > the hackers list as I review the different bits of functionality. I only support two methods for now, but maybe the BeginDrag and other Drag events and methods should also be supported in the new class as in the listview_drag_drop sample. > I hope you don't mind - it should all get in eventually - and we'll work > towards a 1.04 release soon. Not at all. > Reini Urban wrote: > > 2006/3/16, Jeremy White <[EMAIL PROTECTED]>: > > > >>I've just committed changes made by Reini Urban with support for custom draw > >>and "native" drag-drop support. The full change log from 1.03 is below. Any > >>questions or problems to the list. > > > > > > Thanks! > > > > BTW: There are two conflicting lines in the changelog > > - GUI.pm : Change version to 1.04, add -dropfiles to Window > > - Upped version to 1.03_03 > > > > > >>---------------------- > >> > >>+ [Reini Urban] : 15 Mar 2006 > >> - GUI.pm : Change version to 1.04, add -dropfiles to Window > >> - GUI.h : add CustomDraw and DropFiles support, > >> start with thread safe static data definitions. > >> - Button.xs, Header.xs, ListView.xs, Rebar.xs, Toolbar.xs, Tooltip.xs, > >>TreeView.xs: > >> add CustomDraw EVENT with Win32::GUI::Button::CustomDraw object as > >>param. > >> abuse the PAINT constant for NEM, which should not conflict. > >> - CustomDraw.pm : CustomDraw package definition and helpers > >> - GUI.xs : > >>DoEvents(hwnd=NULL,wMsgFilterMin=0,wMsgFilterMax=0,wRemoveMsg=PM_REMOVE), > >> Try additional OEM ressource in LoadImage, > >> Add Win32::GUI::DragDrop object which is passed to the DropFiles > >> event as > >>argument. > >> - GUI_Helpers.cpp: add SV* CreateNMCustomDraw() > >> - GUI_MessageLoops.cpp : Change DropFiles EVENT to pass the > >>Win32::GUI::DragDrop object > >> - ImageList.xs: Add to documention. > >> - TYPEMAP: Add HDROP as first-class citizen (Win32::GUI::DragDrop) > >> - Window.xs: support -dropfiles property, store it onPostCreate in > >>perlcs > >> - SrcParser.pm, Documentation.txt: fix some typos > >> - t/07_CustomDraw.t: added > >> - samples/CustomDraw.pl: added > >> - guard against Win32::GetFileVersion for older perls > >> - guard against undefined NOTIFYICONDATA for older compilers also (<= > >>MSVC98) > >> - Upped version to 1.03_03 > >> > >>+ [Robert May] : 11 Jan 2006 - bug fixes and add balloon tips for Notify > >>Icon > >> - Label.xs correct -truncate option processing, as SS_.*ELLIPSIS.* > >> styles are not single bits > >> - NotifyIcon.xs, GUI_Options.cpp, GUI.pm re-work NofifyIcon > >> class. Add balloon tooltips. Add support for message behaviour. Add > >> support for setfocus. Add documentation. (Tracker: 1065072) > >> - t\05_NotifyIcon*.t, MANIFEST Notify Icon Tests added > >> - samples\NotifyIcon.pl, MANIFEST add demo app > >> - GUI.pm Changed initial value of $Win32::GUI::MenuIdCounter to avoid ID > >> clash with predefined WM_COMMAND values (IDOK, IDCANCEL, etc.) > >> - GUI.xs Fix SendMessageTimeout to match documentation and return > >> undef on failure. (XSRETURN_UNDEF rather than XSRETURN_NO). > >> - GUI.pm corrected documentation of default values for autohscroll > >> and autovscroll in Textfield documentation > >> - GUI_MessageLoops.cpp added processing of WM_NEXTDLGCTL to > >> CommonMessageLoop to allow for tabbing out of multiline Textfields > >> when using -dialogui > >> - GUI_MessageLoops.cpp fixed WM_ERASEBACKGROUND (Tracker:1363141) > >> - Splitter.xs, GUI_Helpers.cpp, GUI.h re-worked splitter class. > >> (Tracker:1363141) > >> - RichEdit.xs made -background and -foreground work > >> - GUI_MessageLoops.cpp made -background work for Splitter windows > >> - GUI_Helpers.cpp removed an unnecessary dTHX, replacing it with > >> PERLUD_FETCH > >> - Upped version to 1.03_02 > >> > >>+ [Robert May] : 3 Dec 2005 - bug fixes > >> - GUI.h change order of instructions in PERLUD_FREE macro to prevent > >> crashes (Trackers 1243378 and 1248578) > >> - GUI.pm up version to 1.03_01 and tidy up > >> - GUI.xs change logic in all message loops (Dialog, DoEvents, DoModal) > >>to > >> prevent memory leak (Tracker: 1201190) > >> - Listbox.xs add documentation to differentiate between SetCurSel and > >> SetSel (Tracker: 1177898) -- Reini Urban http://phpwiki.org/ http://spacemovie.mur.at/ http://helsinki.at/
