why does perl critic not like @_

[John]

Hi

I have just started using perl critic to analyse my code.

I have often used @_ as a temporary array like this:
[code]
    # count internals
    @_ = $h_wk->selectrow_array("SELECT COUNT(*) FROM v_internals");
    my $count_all_internals = shift @_;

    @_ = $h_wk->selectrow_array("SELECT COUNT(*) FROM 
v_completed_internals");
    my $count_completed_internals = shift @_;

    @_ = $h_wk->selectrow_array("SELECT COUNT(*) FROM v_internals "
                                ."  WHERE asset NOT IN 
v_completed_internals");
    my $count_outstanding_internals = shift @_;

    @_ = $h_wk->selectrow_array("SELECT COUNT(*) FROM v_internals_in_work");
    my $count_internals_in_work = shift @_;

    @_ = $h_wk->selectrow_array("SELECT COUNT(*) FROM wkintnls "
                                ."  WHERE asset NOT IN v_internals_in_work "
                                ."    AND asset NOT IN 
v_completed_internals");
    my $count_internals_not_in_work = shift @_;
[/code]

Critic complains with 'Always unpack @_ first', why?
What is so wrong with this usage?

Could someone please enlighten me.

John

-- 
Regards
    John McMahon
       li...@jspect.fastmail.fm


_______________________________________________
Perl-Win32-Users mailing list
Perl-Win32-Users@listserv.ActiveState.com
To unsubscribe: http://listserv.ActiveState.com/mailman/mysubs