-----BEGIN PGP SIGNED MESSAGE----- Moin,
On Monday 07 March 2005 05:15, Jim Cromie wrote: > folks, > > Ive worked up this patch, and would like to get feedback. I second it :) > 1. is it useful ? Yes, very, Devel::Size::Report will use that handy feature :) > 2. are there any glaring or subtle problems ? Not for me. > 3. do you like/dislike the XS to perl callback ? I think a pure XS solution would mabye a bit faster, and maybe work on more Perl versiosn. But then, it would also replicate a lot of work, so not reinventing the wheel is probably best here. > 1. do the sizes look sensible > I think so, but I hav *no* experience with these things. Neither me. Maybe perl5porters can say something about that? > 2. why do both {CODE} and {GLOB} thingies in the stash-val > result in calls to Devel::Size::_sizeCV (my new func) > I would expect former, but not latter. Maybe because a glob also contains code/hash/array/etc at the same time? > 3. It appears that the 'err: coderef $foo has no START' > is result of calling _sizeCV on an XS function. > Does that sound right ? Are there any other causes ? > if Yes, no, then Ill send a patch to blead. > > 4. any point in computing size of binary functions ? > I could imagine doing it with `nm -S` but this is horribly unportable. > It also opens a whole nuther can of worms, since each function > is likely to call lots of others. Just an idea: Are there any markers around the binary functions you could use? Or the cheap "ptr math" trick I mention before? Best wishes and thanx for the hard work, Tels - -- Signed on Sat Mar 12 11:42:28 2005 with key 0x93B84C15. Visit my photo gallery at http://bloodgate.com/photos/ PGP key on http://bloodgate.com/tels.asc or per email. If you are bald, and comb some of your hair over the bald spot, you are violating US Patent #4,022,227: <http://tinyurl.com/6qxl7> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iQEUAwUBQjLIRncLPEOTuEwVAQHDxwf2M4sCVSYfDQ+ZYfPGzr1YHpQYCGaT6XDv sUtcJjoOsy4UMj3J1hcVq/eFx7/NWgfNSvrUXGQWMGd4ISD13SRPg7zRHjAsyFRh DvivAOiqJIitAVU9D+bPI4lOPstMutnX2xbcBPGwTffzdV/82SRXxyhkS8oume// 7XlO87mCsq5LLMzQEgCXJyskD+JgWdy2ICX8MhVgfWqG9jZwpp/+FxLC1sqJavRY jJGKzjiacNUdN70ibi3VHtunMVIS6gi3oA1DSkfbV6DEe8ju1NkiNu5tRGz3lkXb 8CDCLRyHAQ63byXKP/2dx5LBYah7PIUUcgYj+d/OuxZGi4JabqBA =vsuX -----END PGP SIGNATURE-----