On Thu 13 Nov 2003 23:49, Nicholas Clark <[EMAIL PROTECTED]> wrote:
> On Sat, Nov 01, 2003 at 04:10:59PM +0200, H.Merijn Brand wrote:
> > As announced in my plans somewhere back in september 2002, I finally found
> > time to check and change.
>
> Good stuff. Thanks
>
> > --- hints/solaris_2.sh 2003-10-27 18:28:33.000000000 +0100
> > +++ hints/solaris_2.sh 2003-11-01 15:21:43.000000000 +0100
> > @@ -448,15 +448,12 @@
> > exit 1
> > ;;
> > esac
> > - ;;
> > -esac
> > +
> > # gcc-2.8.1 on Solaris 8 with -Duse64bitint fails op/pat.t test 822
> > # if we compile regexec.c with -O. Turn off optimization for that one
> > # file. See hints/README.hints , especially
> > # =head2 Propagating variables to config.sh, method 3.
> > # A. Dougherty May 24, 2002
> > -case "$use64bitint" in
> > -"$define")
> > case "${gccversion}-${optimize}" in
> > 2.8*-O*)
> > # Honor a command-line override (rather unlikely)
> > End-of-patch
>
> You seem to take out an esac without putting it back in anywhere?
> How does this work? From inspection of just the patch, doesn't this
> make things unbalanced?
No, it is^Wwas like
case "use64bitint" in
"$define")
...
esac
case "use64bitint" in
"$define")
...
esac
kinda useless to do it like this, so I took the middle three lines out
> Nicholas Clark
--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.0, & 5.9.x, and 806 on HP-UX 10.20 & 11.00, 11i,
AIX 4.3, SuSE 8.2, and Win2k. http://www.cmve.net/~merijn/
http://archives.develooper.com/[EMAIL PROTECTED]/ [EMAIL PROTECTED]
send smoke reports to: [EMAIL PROTECTED], QA: http://qa.perl.org
