Change 11516 by jhi@alpha on 2001/07/31 14:14:35
Add -Wall in cflags, not in Configure.
(This way -Wall affects only the core and the core XS,
not user modules' XS. Concern from Paul Marquess,
implementation idea from Andy Dougherty.)
Affected files ...
... //depot/perl/Configure#345 edit
... //depot/perl/cflags.SH#18 edit
Differences ...
==== //depot/perl/Configure#345 (xtext) ====
Index: perl/Configure
--- perl/Configure.~1~ Tue Jul 31 08:30:05 2001
+++ perl/Configure Tue Jul 31 08:30:05 2001
@@ -20,7 +20,7 @@
# $Id: Head.U,v 3.0.1.9 1997/02/28 15:02:09 ram Exp $
#
-# Generated on Tue Jul 31 17:53:39 EET DST 2001 [metaconfig 3.0 PL70]
+# Generated on Tue Jul 31 18:10:25 EET DST 2001 [metaconfig 3.0 PL70]
# (with additional metaconfig patches by [EMAIL PROTECTED])
cat >c1$$ <<EOF
@@ -3519,14 +3519,6 @@
'') ccname="$cc" ;;
esac
-case "$gccversion" in
-'') ;;
-*) case "$ccflags" in
- *-Wall*) ;;
- *) ccflags="$ccflags -Wall" ;;
- esac
- ;;
-esac
: decide how portable to be. Allow command line overrides.
case "$d_portable" in
==== //depot/perl/cflags.SH#18 (xtext) ====
Index: perl/cflags.SH
--- perl/cflags.SH.~1~ Tue Jul 31 08:30:05 2001
+++ perl/cflags.SH Tue Jul 31 08:30:05 2001
@@ -138,9 +138,25 @@
optimize="$optdebug"
fi
+# Add -Wall for the core and core modules iff gcc and not already -Wall
+warn=''
+case "$gccversion" in
+'') ;;
+*) case "$ccflags" in
+ *-Wall*) ;;
+# Can't add -ansi here because it will fail e.g. in Solaris.
+# Off_t/off_t is a struct in Solaris with largefiles, and with -ansi
+# that struct cannot be compared with a flat integer, such as a STRLEN.
+# The -ansi will also cause a lot of noise in Solaris because of:
+# /usr/include/sys/resource.h:148: warning: `struct rlimit64' declared inside
+parameter list
+ *) warn='-Wall' ;;
+ esac
+ ;;
+esac
+
: Can we perhaps use $ansi2knr here
- echo "$cc -c -DPERL_CORE $ccflags $optimize $perltype"
- eval "$also "'"$cc -DPERL_CORE -c $ccflags $optimize $perltype"'
+ echo "$cc -c -DPERL_CORE $ccflags $optimize $warn $perltype"
+ eval "$also "'"$cc -DPERL_CORE -c $ccflags $optimize $warn $perltype"'
. $TOP/config.sh
End of Patch.
