Change 11712 by jhi@alpha on 2001/08/18 03:22:24
Fix for ID 20010407.006: PL_reg_sv got wiped out
by freetemps if the match target was a temporary,
which in turn meant that the $1 et al stopped working.
Therefore bump up the refcount of PL_reg_sv.
Affected files ...
... //depot/perl/pp_hot.c#251 edit
... //depot/perl/t/op/pat.t#114 edit
Differences ...
==== //depot/perl/pp_hot.c#251 (text) ====
Index: perl/pp_hot.c
--- perl/pp_hot.c.~1~ Fri Aug 17 21:30:05 2001
+++ perl/pp_hot.c Fri Aug 17 21:30:05 2001
@@ -1222,7 +1222,7 @@
TARG = DEFSV;
EXTEND(SP,1);
}
- PL_reg_sv = TARG;
+ PL_reg_sv = SvREFCNT_inc(TARG);
PUTBACK; /* EVAL blocks need stack_sp. */
s = SvPV(TARG, len);
strend = s + len;
@@ -1909,7 +1909,7 @@
TARG = DEFSV;
EXTEND(SP,1);
}
- PL_reg_sv = TARG;
+ PL_reg_sv = SvREFCNT_inc(TARG);
do_utf8 = DO_UTF8(PL_reg_sv);
if (SvFAKE(TARG) && SvREADONLY(TARG))
sv_force_normal(TARG);
==== //depot/perl/t/op/pat.t#114 (xtext) ====
Index: perl/t/op/pat.t
--- perl/t/op/pat.t.~1~ Fri Aug 17 21:30:05 2001
+++ perl/t/op/pat.t Fri Aug 17 21:30:05 2001
@@ -6,7 +6,7 @@
$| = 1;
-print "1..684\n";
+print "1..686\n";
BEGIN {
chdir 't' if -d 't';
@@ -1987,3 +1987,22 @@
$c = pos;
print "$a $b $c" eq 'ba:ba ad:ae 10' ? "ok 684\n" : "not ok 684\t# $a $b $c\n";
}
+
+{
+ package ID_20010407_006;
+
+ sub x {
+ "a\x{1234}";
+ }
+
+ my $x = x;
+ my $y;
+
+ $x =~ /(..)/; $y = $1;
+ print "not " unless length($y) == 2 && $y eq $x;
+ print "ok 685\n" if length($y) == 2;
+
+ x =~ /(..)/; $y = $1;
+ print "not " unless length($y) == 2 && $y eq $x;
+ print "ok 686\n";
+}
End of Patch.
