Change 11768 by ams@ams-lustre on 2001/08/28 00:47:35
Subject: Re: [PATCH pod/perlhack.pod t/op/pack.t] Fixing bad testing advice
From: Michael G Schwern <[EMAIL PROTECTED]>
Date: Mon, 27 Aug 2001 21:24:44 -0400
Message-Id: <20010827212444.F12582@blackrider>
Affected files ...
... //depot/perl/pod/perlhack.pod#34 edit
... //depot/perl/t/op/pack.t#40 edit
Differences ...
==== //depot/perl/pod/perlhack.pod#34 (text) ====
Index: perl/pod/perlhack.pod
--- perl/pod/perlhack.pod.~1~ Mon Aug 27 19:00:06 2001
+++ perl/pod/perlhack.pod Mon Aug 27 19:00:06 2001
@@ -1482,8 +1482,13 @@
my $test = 1;
sub ok {
my($ok) = @_;
- print "not " unless $ok;
- print "ok $test\n";
+
+ # You have to do it this way or VMS will get confused.
+ my $out = '';
+ $out = "not " unless $ok;
+ $out .= "ok $test\n";
+ print $out;
+
$test++;
return $ok;
}
==== //depot/perl/t/op/pack.t#40 (xtext) ====
Index: perl/t/op/pack.t
--- perl/t/op/pack.t.~1~ Mon Aug 27 19:00:06 2001
+++ perl/t/op/pack.t Mon Aug 27 19:00:06 2001
@@ -12,12 +12,18 @@
my $test = 1;
sub ok {
my($ok) = @_;
- print "not " unless $ok;
- print "ok $test\n";
+
+ # You have to do it this way or VMS will get confused.
+ my $out = '';
+ $out = "not " unless $ok;
+ $out .= "ok $test\n";
+ print $out;
+
$test++;
return $ok;
}
+
print "1..161\n";
# Note: All test numbers in comments are off by 1 after the comment below..
End of Patch.
