Change 11916 by jhi@alpha on 2001/09/06 13:56:19
Subject: Extra NUL is Data::Dumper output - patch
From: Tony Cook <[EMAIL PROTECTED]>
Date: Thu, 6 Sep 2001 12:35:49 +1000 (EST)
Message-ID: <[EMAIL PROTECTED]>
Affected files ...
... //depot/perl/ext/Data/Dumper/Dumper.xs#26 edit
... //depot/perl/ext/Data/Dumper/t/dumper.t#2 edit
Differences ...
==== //depot/perl/ext/Data/Dumper/Dumper.xs#26 (text) ====
Index: perl/ext/Data/Dumper/Dumper.xs
--- perl/ext/Data/Dumper/Dumper.xs.~1~ Thu Sep 6 08:00:06 2001
+++ perl/ext/Data/Dumper/Dumper.xs Thu Sep 6 08:00:06 2001
@@ -137,7 +137,7 @@
r[0] = r[j++] = '"';
else
r[0] = r[j++] = '\'';
- r[j++] = '\0';
+ r[j] = '\0';
SvCUR_set(sv, SvCUR(sv) + j);
return j;
==== //depot/perl/ext/Data/Dumper/t/dumper.t#2 (xtext) ====
Index: perl/ext/Data/Dumper/t/dumper.t
--- perl/ext/Data/Dumper/t/dumper.t.~1~ Thu Sep 6 08:00:06 2001
+++ perl/ext/Data/Dumper/t/dumper.t Thu Sep 6 08:00:06 2001
@@ -61,11 +61,11 @@
if (defined &Data::Dumper::Dumpxs) {
print "### XS extension loaded, will run XS tests\n";
- $TMAX = 186; $XS = 1;
+ $TMAX = 192; $XS = 1;
}
else {
print "### XS extensions not loaded, will NOT run XS tests\n";
- $TMAX = 93; $XS = 0;
+ $TMAX = 96; $XS = 0;
}
print "1..$TMAX\n";
@@ -808,3 +808,16 @@
TEST q(Data::Dumper->new([$b],['b'])->Purity(1)->Dumpxs;)
if $XS;
}
+
+{
+ $a = "\x{09c10}";
+############# 187
+## XS code was adding an extra \0
+ $WANT = <<'EOT';
+#$a = "\x{9c10}";
+EOT
+
+ TEST q(Data::Dumper->Dump([$a], ['a']));
+ TEST q(Data::Dumper->Dumpxs([$a], ['a']));
+
+}
End of Patch.
