Change 13472: Re: [PATCH] File::Basename pod and .t (was: perlpacktut.pod v0.0 (split))

[Jarkko Hietaniemi]

Change 13472 by jhi@alpha on 2001/12/05 13:30:47

        Subject: Re: [PATCH] File::Basename pod and .t (was: perlpacktut.pod v0.0 
(split))
        From: Wolfgang Laun <[EMAIL PROTECTED]>
        Date: Wed, 05 Dec 2001 10:49:20 +0100
        Message-ID: <[EMAIL PROTECTED]>

Affected files ...

.... //depot/perl/lib/File/Basename.pm#27 edit
.... //depot/perl/lib/File/Basename.t#2 edit

Differences ...

==== //depot/perl/lib/File/Basename.pm#27 (text) ====
Index: perl/lib/File/Basename.pm
--- perl/lib/File/Basename.pm.~1~       Wed Dec  5 06:45:05 2001
+++ perl/lib/File/Basename.pm   Wed Dec  5 06:45:05 2001
@@ -17,9 +17,9 @@
     $basename = basename($fullname,@suffixlist);
     $dirname = dirname($fullname);
 
-    ($name,$path,$suffix) = fileparse("lib/File/Basename.pm","\.pm");
+    ($name,$path,$suffix) = fileparse("lib/File/Basename.pm",qr{\.pm});
     fileparse_set_fstype("VMS");
-    $basename = basename("lib/File/Basename.pm",".pm");
+    $basename = basename("lib/File/Basename.pm",qr{\.pm});
     $dirname = dirname("lib/File/Basename.pm");
 
 =head1 DESCRIPTION
@@ -60,7 +60,8 @@
 separator in the input file specification.  The remainder of the input
 file specification is then divided into B<name> and B<suffix> based on
 the optional patterns you specify in C<@suffixlist>.  Each element of
-this list is interpreted as a regular expression, and is matched
+this list can be a qr-quoted pattern (or a string which is interpreted
+as a regular expression), and is matched
 against the end of B<name>.  If this succeeds, the matching portion of
 B<name> is removed and prepended to B<suffix>.  By proper use of
 C<@suffixlist>, you can remove file types or versions for examination.
@@ -76,7 +77,7 @@
 Using Unix file syntax:
 
     ($base,$path,$type) = fileparse('/virgil/aeneid/draft.book7',
-                                   '\.book\d+');
+                                   qr{\.book\d+});
 
 would yield
 
@@ -87,7 +88,7 @@
 Similarly, using VMS syntax:
 
     ($name,$dir,$type) = fileparse('Doc_Root:[Help]Rhetoric.Rnh',
-                                  '\..*');
+                                  qr{\..*});
 
 would yield
 

==== //depot/perl/lib/File/Basename.t#2 (xtext) ====
Index: perl/lib/File/Basename.t
--- perl/lib/File/Basename.t.~1~        Wed Dec  5 06:45:05 2001
+++ perl/lib/File/Basename.t    Wed Dec  5 06:45:05 2001
@@ -18,7 +18,7 @@
         '' : 'not '),"ok 2\n";
 
 # Unix syntax tests
-($base,$path,$type) = fileparse('/virgil/aeneid/draft.book7','\.book\d+');
+($base,$path,$type) = fileparse('/virgil/aeneid/draft.book7',qr'\.book\d+');
 if ($base eq 'draft' and $path eq '/virgil/aeneid/' and $type eq '.book7') {
   print "ok 3\n";
 }
@@ -37,7 +37,7 @@
         '' : 'not '),"ok 8\n";
 
 # VMS syntax tests
-($base,$path,$type) = fileparse('virgil:[aeneid]draft.book7','\.book\d+');
+($base,$path,$type) = fileparse('virgil:[aeneid]draft.book7',qr{\.book\d+});
 if ($base eq 'draft' and $path eq 'virgil:[aeneid]' and $type eq '.book7') {
   print "ok 9\n";
 }
End of Patch.