Change 15027 by jhi@alpha on 2002/03/04 23:48:07

        One more nit from mjd.

Affected files ...

.... //depot/perl/lib/Tie/File/t/16_handle.t#4 edit

Differences ...

==== //depot/perl/lib/Tie/File/t/16_handle.t#4 (text) ====
Index: perl/lib/Tie/File/t/16_handle.t
--- perl/lib/Tie/File/t/16_handle.t.~1~ Mon Mar  4 17:00:05 2002
+++ perl/lib/Tie/File/t/16_handle.t     Mon Mar  4 17:00:05 2002
@@ -78,19 +78,34 @@
 untie @a;
 
 # Does it correctly detect a non-seekable handle?
-{  eval {pipe *R, *W};
-   close R;
-   if ($@) {
-     print "ok $N # skipped\n";
-     last;
-   }
-   $o = eval {tie @a, 'Tie::File', \*W};
-   if ($@ && $@ =~ /filehandle does not appear to be seekable/) {
-     print "ok $N\n";
-   } else {
-     print "not ok $N # $@\n";
-   }
-   $N++;
+
+{
+  if ($^O =~ /^(MSWin32|dos)$/) {
+    print "ok $N \# skipped ($^O has broken pipe semantics)\n";
+    last;
+  }
+  my $pipe_succeeded = eval {pipe *R, *W};
+  if ($@) {
+    chomp $@;
+    print "ok $N \# skipped (no pipes: $@)\n";
+        last;
+  } elsif (! $pipe_succeeded) {
+    print "ok $N \# skipped (pipe call failed: $!)\n";
+    last;
+  }
+  close R;
+  $o = eval {tie @a, 'Tie::File', \*W};
+  if ($@) {
+    if ($@ =~ /filehandle does not appear to be seekable/) {
+      print "ok $N\n";
+    } else {
+      chomp $@;
+      print "not ok $N \# \$\@ is $@\n";
+    }
+  } else {
+    print "not ok $N \# passing pipe to TIEARRAY didn't abort program\n";
+  }
+  $N++;
 }
 
 # try inserting a record into the middle of an empty file
End of Patch.

Reply via email to