Change 16434 by jhi@alpha on 2002/05/06 15:29:58
Subject: Re: [proposed PATCH] correctly unlocalise exists on tied/%ENV
From: Dave Mitchell <[EMAIL PROTECTED]>
Date: Mon, 6 May 2002 17:17:00 +0100
Message-ID: <[EMAIL PROTECTED]>
Affected files ...
.... //depot/perl/pod/perldelta.pod#366 edit
.... //depot/perl/t/op/local.t#19 edit
Differences ...
==== //depot/perl/pod/perldelta.pod#366 (text) ====
Index: perl/pod/perldelta.pod
--- perl/pod/perldelta.pod#365~16432~ Mon May 6 06:29:22 2002
+++ perl/pod/perldelta.pod Mon May 6 08:29:58 2002
@@ -544,8 +544,8 @@
=item *
-Tied hash interfaces are now required to have the EXISTS method
-(either own or inherited).
+Tied hash interfaces are now required to have the EXISTS and DELETE
+methods (either own or inherited).
=item *
@@ -1946,8 +1946,8 @@
=item *
-Localised hash elements are correctly unlocalised to not to exist,
-if that's what they where.
+Localised hash elements (and %ENV) are correctly unlocalised to not to
+exist, if that's what they where.
use Tie::Hash;
@@ -1963,7 +1963,7 @@
# but no more so.
As a side effect of this fix, tied hash interfaces B<must> define
-the EXISTS method.
+the EXISTS and DELETE methods.
=item *
==== //depot/perl/t/op/local.t#19 (xtext) ====
Index: perl/t/op/local.t
--- perl/t/op/local.t#18~16431~ Mon May 6 06:13:00 2002
+++ perl/t/op/local.t Mon May 6 08:29:58 2002
@@ -1,6 +1,6 @@
#!./perl
-print "1..71\n";
+print "1..75\n";
sub foo {
local($a, $b) = @_;
@@ -142,6 +142,8 @@
{
local($h{'a'}) = 'foo';
local($h{'b'}) = $h{'b'};
+ local($h{'y'});
+ local($h{'z'}) = 33;
print +($h{'a'} eq 'foo') ? "" : "not ", "ok 42\n";
print +($h{'b'} == 2) ? "" : "not ", "ok 43\n";
local($h{'c'});
@@ -183,6 +185,8 @@
$ENV{_Y_} = 'b';
$ENV{_Z_} = 'c';
{
+ local($ENV{_A_});
+ local($ENV{_B_}) = 'foo';
local($ENV{_X_}) = 'foo';
local($ENV{_Y_}) = $ENV{_Y_};
print +($ENV{_X_} eq 'foo') ? "" : "not ", "ok 54\n";
@@ -244,3 +248,12 @@
print "not " if exists $x{c};
print "ok 71\n";
}
+
+# these tests should be physically located after tests 46 and 58,
+# but are here instead to avoid renumbering everything.
+
+# local() should preserve the existenceness of tied hashes and %ENV
+print "not " if exists $h{'y'}; print "ok 72\n";
+print "not " if exists $h{'z'}; print "ok 73\n";
+print "not " if exists $ENV{_A_}; print "ok 74\n";
+print "not " if exists $ENV{_B_}; print "ok 75\n";
End of Patch.
