Change 18036 by [EMAIL PROTECTED] on 2002/10/20 13:43:56
Subject: Re: [perl #17892] Perl's mkdir() doesn't remove trailing slashes
From: Slaven Rezic <[EMAIL PROTECTED]>
Date: 14 Oct 2002 09:37:18 +0200
Message-ID: <[EMAIL PROTECTED]>
Affected files ...
.... //depot/perl/pp_sys.c#321 edit
.... //depot/perl/t/op/mkdir.t#15 edit
Differences ...
==== //depot/perl/pp_sys.c#321 (text) ====
Index: perl/pp_sys.c
--- perl/pp_sys.c#320~17953~ Wed Oct 2 05:55:29 2002
+++ perl/pp_sys.c Sun Oct 20 06:43:56 2002
@@ -3711,7 +3711,7 @@
* -d, chdir(), chmod(), chown(), chroot(), fcntl()?,
* (mkdir()), opendir(), rename(), rmdir(), stat(). --jhi */
if (len > 1 && tmps[len-1] == '/') {
- while (tmps[len] == '/' && len > 1)
+ while (tmps[len-1] == '/' && len > 1)
len--;
tmps = savepvn(tmps, len);
copy = TRUE;
==== //depot/perl/t/op/mkdir.t#15 (xtext) ====
Index: perl/t/op/mkdir.t
--- perl/t/op/mkdir.t#14~10847~ Fri Jun 22 14:50:38 2001
+++ perl/t/op/mkdir.t Sun Oct 20 06:43:56 2002
@@ -1,6 +1,6 @@
#!./perl
-print "1..9\n";
+print "1..13\n";
BEGIN {
chdir 't' if -d 't';
@@ -23,3 +23,8 @@
print ($! =~ /cannot find|such|exist|not found|not a directory/i ? "ok 7\n" : "#
$!\nnot ok 7\n");
print (mkdir('blurfl') ? "ok 8\n" : "not ok 8\n");
print (rmdir('blurfl') ? "ok 9\n" : "not ok 9\n");
+# trailing slashes will be removed before the system call to mkdir
+print (mkdir('blurfl///') ? "ok 10\n" : "not ok 10\n");
+print (-d 'blurfl' ? "ok 11\n" : "not ok 11\n");
+print (rmdir('blurfl///') ? "ok 12\n" : "not ok 12\n");
+print (!-d 'blurfl' ? "ok 13\n" : "not ok 13\n");
End of Patch.
