Change 18521 by jhi@lyta on 2003/01/20 17:37:35

        Retract #18154 (integrate of perlio #18507), not enough
        threadsafety.

Affected files ...

... //depot/perl/perlio.c#198 edit

Differences ...

==== //depot/perl/perlio.c#198 (text) ====
Index: perl/perlio.c
--- perl/perlio.c#197~18514~    Sat Jan 18 10:36:00 2003
+++ perl/perlio.c       Mon Jan 20 09:37:35 2003
@@ -2708,13 +2708,6 @@
            }
            else {
                /* Tricky - must fclose(stdio) to free memory but not close(fd) */ 
-#ifdef USE_THREADS
-               /* Sarathy pointed out that another thread could reuse
-                  fd after fclose() but before we dup2() below
-                  so take out a MUTEX to shut them out 
-                */  
-               MUTEX_LOCK(&PerlIO_mutex);
-#endif
                dupfd = PerlLIO_dup(fd);
            }
        }    
@@ -2732,14 +2725,12 @@
            /* We need to restore fd from the saved copy */
            if (PerlLIO_dup2(dupfd,fd) != fd)
              result = -1;
-#ifdef USE_THREADS
-           MUTEX_UNLOCK(&PerlIO_mutex);
-#endif
            if (PerlLIO_close(dupfd) != 0)
              result = -1; 
        }
        return result;
     } 
+
 }
 
 
End of Patch.

Reply via email to