Change 20653 by [EMAIL PROTECTED] on 2003/08/12 13:15:17
Retract #20644 and #20643; on non-microperl non-fcntl
systems Wrong Thing would be done. (And as Sarathy
points out, closing both ends of a pipe is rather
identical to never opening it...)
Affected files ...
... //depot/perl/pp_sys.c#350 edit
... //depot/perl/util.c#400 edit
Differences ...
==== //depot/perl/pp_sys.c#350 (text) ====
Index: perl/pp_sys.c
--- perl/pp_sys.c#349~20646~ Tue Aug 12 04:51:25 2003
+++ perl/pp_sys.c Tue Aug 12 06:15:17 2003
@@ -4138,8 +4138,6 @@
PerlLIO_close(pp[0]);
#if defined(HAS_FCNTL) && defined(F_SETFD)
fcntl(pp[1], F_SETFD, FD_CLOEXEC);
-#else
- PerlLIO_close(pp[1]); /* Do as best as we can: pretend success. */
#endif
}
if (PL_op->op_flags & OPf_STACKED) {
==== //depot/perl/util.c#400 (text) ====
Index: perl/util.c
--- perl/util.c#399~20646~ Tue Aug 12 04:51:25 2003
+++ perl/util.c Tue Aug 12 06:15:17 2003
@@ -1821,8 +1821,6 @@
#if defined(HAS_FCNTL) && defined(F_SETFD)
/* Close error pipe automatically if exec works */
fcntl(pp[1], F_SETFD, FD_CLOEXEC);
-#else
- PerlLIO_close(pp[1]); /* Do as best as we can: pretend success. */
#endif
}
/* Now dup our end of _the_ pipe to right position */
@@ -1962,8 +1960,6 @@
PerlLIO_close(pp[0]);
#if defined(HAS_FCNTL) && defined(F_SETFD)
fcntl(pp[1], F_SETFD, FD_CLOEXEC);
-#else
- PerlLIO_close(pp[1]); /* Do as best as we can: pretend success. */
#endif
}
if (p[THIS] != (*mode == 'r')) {
End of Patch.
