> > > A generally useful hunk from Ilya's microperl patch. > > > (If no fcntl F_SETFD, fake it the best we can.) > > > > This doesn't look correct. pp[1] is closed, but the stale > > fd is passed into the do_*exec*() calls below. If the exec() > > fails, those functions will scribble into someone else's fd. > > > > Why not avoid the creation of the error pipe for the crippled > > platforms in the first place? Closing both ends of a pipe > > pretty much means you never needed it to begin with. :) --GSAR > > Honestly, in this case I don't much care... This is about
Hmmm. Lemme me renege on that ... we might be building a non-microperl on a non-fcntl system, in which case the closing is not good. So yes, I think I'll retract those two changes. > building microperl, which means that we shouldn't be calling > system() anyway. -- Jarkko Hietaniemi <[EMAIL PROTECTED]> http://www.iki.fi/jhi/ "There is this special biologist word we use for 'stable'. It is 'dead'." -- Jack Cohen
